-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add unref for input in readline #38019
Conversation
5921b8f
to
a5fe4a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the PR. :)
Could you please address this review comment from a previous PR attempt to fix the related issue: #36458 (comment)?
I'm not sure this warrants its own section. Seems like it should go in the section of whatever call might result in requiring the
unref()
call. It would be good to incorporate it into an existing section, I think.
nit: I think the commit message should say Fixes
instead of Ref
(but that can be fixed while landing).
@RaisinTen - Thanks for the review!
I did incorporate the edits into an existing section instead of making a new section i.e. |
The wait on the readable stream can also be ended by these calls: readable.destroy();
readable.pause();
readable.unshift(null); Should we also document these here? |
@RaisinTen Sure, we could do it in both places (readable and readline). Do you think it makes sense to add the following in the
|
baedee8
to
33a1f72
Compare
FWIW I don't think it's necessary: I think it's irrelevant to a user trying to interface with |
9542437
to
46e15e5
Compare
PR-URL: nodejs#38019 Fixes: nodejs#36154 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
ced82e4
to
7980d7c
Compare
Landed in 7980d7c |
PR-URL: #38019 Fixes: #36154 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
PR-URL: #38019 Fixes: #36154 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
PR-URL: #38019 Fixes: #36154 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Fixes: #36154