lib: add brand checks to AbortController and AbortSignal #37720
Conversation
|
Can you add tests? |
|
@aduh95 Ah, I see, there's a
|
Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: James M Snell <[email protected]>
|
Okay, so my correction on my initial assumption was wrong. 😅 As Domenic pointed out, the IDL harness does try to call getters and methods with a "bad" receiver to check if they throw a Once Node can run the IDL tests, we can remove these newly added tests. But for now, they are necessary, so I'll leave them in. |
aduh95
added
the
author ready
PR-URL: #37720 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
|
Landed in feaeb76 |
PR-URL: #37720 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#37720 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#37720 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#37720 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #37720 Backport-PR-URL: #38386 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
targos
added
backported-to-v14.x
and removed
author ready
Web IDL specifies that both attributes and operations of IDL interfaces should throw a
TypeErrorifthisdoes not implement the interface. These brand checks were missing forAbortControllerandAbortSignal(as noticed here), so I added them.Unfortunately, this is not straightforward to test. WPT has an IDL test for this, but it's bunched up together with other IDL tests for
EventTarget,EventandCustomEvent. Node supports the first two but not the last one, so the test would still fail. 😕 Suggestions are welcome!