Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: add separate error for INVALID_KEY_TYPE #37555

Closed
wants to merge 3 commits into from
Closed

crypto: add separate error for INVALID_KEY_TYPE #37555

wants to merge 3 commits into from

Conversation

RaisinTen
Copy link
Contributor

This addresses these TODO comments:

node/src/crypto/crypto_cipher.h

Lines 228 to 231 in e6cbec5

case WebCryptoCipherStatus::INVALID_KEY_TYPE:
// Fall through
// TODO(@jasnell): Separate error for this
case WebCryptoCipherStatus::FAILED: {

node/src/crypto/crypto_keys.h

Lines 348 to 351 in e6cbec5

case WebCryptoKeyExportStatus::INVALID_KEY_TYPE:
// Fall through
// TODO(@jasnell): Separate error for this
case WebCryptoKeyExportStatus::FAILED: {

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Mar 1, 2021
@RaisinTen
Copy link
Contributor Author

cc @jasnell

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36420/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36424/

addaleax
addaleax approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could also expand CryptoErrorVector in the future to forward error codes, rather than just plain strings, so that the errors become more programatically accessible?

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 2, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36444/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 4, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/36468/ 💛

@RaisinTen RaisinTen requested a review from jasnell March 5, 2021 15:24
@jasnell
Copy link
Member

jasnell commented Mar 5, 2021

Landed in 03942ca

@jasnell jasnell closed this Mar 5, 2021
jasnell pushed a commit that referenced this pull request Mar 5, 2021
@RaisinTen @jasnell
crypto: add separate error for INVALID_KEY_TYPE
03942ca 
PR-URL: #37555
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RaisinTen RaisinTen deleted the crypto/add-separate-error-for-INVALID_KEY_TYPE branch March 6, 2021 13:54
@RaisinTen RaisinTen mentioned this pull request Mar 7, 2021
Merged
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@RaisinTen @danielleadams
crypto: add separate error for INVALID_KEY_TYPE
33180fa 
PR-URL: #37555
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RaisinTen @nodejs-github-bot @jasnell @addaleax @targos