Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fixup flaky test-performance-function-async test #37493

Closed
wants to merge 1 commit into from
Closed

test: fixup flaky test-performance-function-async test #37493

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 23, 2021

The time assertion was inaccurate. Just remove it as it's not strictly necessary. Recommend fast track.

image

@jasnell
test: fixup flaky test-performance-function-async test
527d2e5 
The time assertion was inaccurate. Just remove it as it's
not strictly necessary
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 23, 2021
@jasnell jasnell added fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Feb 23, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 23, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/36317/ 💚

@jasnell
Copy link
Member Author

jasnell commented Feb 23, 2021

👍🏻 to fast track

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 23, 2021
mhdawson
mhdawson approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member Author

jasnell commented Feb 23, 2021

Landed in ecc5842

jasnell added a commit that referenced this pull request Feb 23, 2021
@jasnell
test: fixup flaky test-performance-function-async test
ecc5842 
The time assertion was inaccurate. Just remove it as it's
not strictly necessary

PR-URL: #37493
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@jasnell jasnell closed this Feb 23, 2021
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @nodejs-github-bot @lpinca @mhdawson @targos