Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 7.5.0 #37117

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 7.5.0 #37117

wants to merge 1 commit into from

Conversation

ruyadorno
Copy link
Member

v7.5.0 (2021-01-28)

FEATURES

BUG FIXES

  • d2f8af2da #2445 publish: don't complain about missing auth until after registry is chosen (@dr-js)

DOCUMENTATION

DEPENDENCIES

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Jan 28, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35804/

MylesBorins
MylesBorins approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZYSzys
ZYSzys approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@ZYSzys ZYSzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@MylesBorins
Copy link
Contributor

fast track?

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 29, 2021
@targos
Copy link
Member

targos commented Jan 29, 2021

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2604/

@ruyadorno ruyadorno added the notable-change PRs with changes that should be highlighted in changelogs. label Jan 29, 2021
@ruyadorno
Copy link
Member Author

ruyadorno commented Jan 29, 2021 •
edited
Loading

@targos I think it'd be worth adding a bullet point to mention the addition of the npm diff command along with this version update 😊

@ruyadorno
Copy link
Member Author

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2604/

😞 we shipped a bunch of peer deps fixes but it looks like koa and acorn targets are still failing, thanks @targos for the reminder/run - I'll circle back with the team on these

@ruyadorno
Copy link
Member Author

ruyadorno commented Jan 29, 2021 •
edited
Loading

I already have the feedback from the team that we have more patches aligned and we're aiming to ship a v7.5.1 by at most next Monday 😊 ref: npm/arborist#214

@targos I'll leave it to your discretion as the releaser whether to try and include this [email protected] patch in the upcoming release or not (I know it might be too late depending on when you're aiming to cut the proposal branch) 👍 as we discussed before it's a problem that was already affecting previous versions of the npm cli and not a regression introduced by this update so I'm comfortable with merging this PR as-is.

@ruyadorno
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/35804/

@ruyadorno
Copy link
Member Author

Landed in d3906ae

@ruyadorno ruyadorno closed this Jan 30, 2021
ruyadorno added a commit that referenced this pull request Jan 30, 2021
@ruyadorno
deps: upgrade npm to 7.5.0
d3906ae 
PR-URL: #37117
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@targos
Copy link
Member

targos commented Jan 30, 2021

@ruyadorno thanks for the heads up! I'll try to wait for v7.5.1 :)

@richardlau richardlau mentioned this pull request Feb 1, 2021
Closed
targos pushed a commit that referenced this pull request Feb 2, 2021
@ruyadorno @targos
deps: upgrade npm to 7.5.0
0346043 
PR-URL: #37117
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
targos added a commit that referenced this pull request Feb 2, 2021
@targos
2021-02-02, Version 15.8.0 (Current)
3f18373 
Notable changes:

crypto:
  * (SEMVER-MINOR) add generatePrime/checkPrime (James M Snell) #36997
  * (SEMVER-MINOR) experimental (Ed/X)25519/(Ed/X)448 support (James M Snell) #36879
deps:
  * upgrade npm to 7.5.0 (Ruy Adorno) #37117
dgram:
  * (SEMVER-MINOR) support AbortSignal in createSocket (Nitzan Uziely) #37026
doc:
  * add Zijian Liu to collaborators (ZiJian Liu) #37075
esm:
  * deprecate legacy main lookup for modules (Guy Bedford) #36918
readline:
  * (SEMVER-MINOR) add history event and option to set initial history (Mattias Runge-Broberg) #33662
  * (SEMVER-MINOR) add support for the AbortController to the question method (Mattias Runge-Broberg) #33676

PR-URL: TODO
@targos targos mentioned this pull request Feb 2, 2021
Merged
targos added a commit that referenced this pull request Feb 2, 2021
@targos
2021-02-02, Version 15.8.0 (Current)
5a59dde 
Notable changes:

crypto:
  * (SEMVER-MINOR) add generatePrime/checkPrime (James M Snell) #36997
  * (SEMVER-MINOR) experimental (Ed/X)25519/(Ed/X)448 support (James M Snell) #36879
deps:
  * upgrade npm to 7.5.0 (Ruy Adorno) #37117
dgram:
  * (SEMVER-MINOR) support AbortSignal in createSocket (Nitzan Uziely) #37026
doc:
  * add Zijian Liu to collaborators (ZiJian Liu) #37075
esm:
  * deprecate legacy main lookup for modules (Guy Bedford) #36918
readline:
  * (SEMVER-MINOR) add history event and option to set initial history (Mattias Runge-Broberg) #33662
  * (SEMVER-MINOR) add support for the AbortController to the question method (Mattias Runge-Broberg) #33676

PR-URL: #37183
targos added a commit that referenced this pull request Feb 2, 2021
@targos
2021-02-02, Version 15.8.0 (Current)
bc1c428 
Notable changes:

crypto:
  * (SEMVER-MINOR) add generatePrime/checkPrime (James M Snell) #36997
  * (SEMVER-MINOR) experimental (Ed/X)25519/(Ed/X)448 support (James M Snell) #36879
deps:
  * upgrade npm to 7.5.0 (Ruy Adorno) #37117
dgram:
  * (SEMVER-MINOR) support AbortSignal in createSocket (Nitzan Uziely) #37026
doc:
  * add Zijian Liu to collaborators (ZiJian Liu) #37075
esm:
  * deprecate legacy main lookup for modules (Guy Bedford) #36918
readline:
  * (SEMVER-MINOR) add history event and option to set initial history (Mattias Runge-Broberg) #33662
  * (SEMVER-MINOR) add support for the AbortController to the question method (Mattias Runge-Broberg) #33676

PR-URL: #37183
targos added a commit that referenced this pull request Feb 2, 2021
@targos
2021-02-02, Version 15.8.0 (Current)
211574b 
Notable changes:

crypto:
  * (SEMVER-MINOR) add generatePrime/checkPrime (James M Snell) #36997
  * (SEMVER-MINOR) experimental (Ed/X)25519/(Ed/X)448 support (James M Snell) #36879
deps:
  * upgrade npm to 7.5.0 (Ruy Adorno) #37117
dgram:
  * (SEMVER-MINOR) support AbortSignal in createSocket (Nitzan Uziely) #37026
doc:
  * add Zijian Liu to collaborators (ZiJian Liu) #37075
esm:
  * deprecate legacy main lookup for modules (Guy Bedford) #36918
readline:
  * (SEMVER-MINOR) add history event and option to set initial history (Mattias Runge-Broberg) #33662
  * (SEMVER-MINOR) add support for the AbortController to the question method (Mattias Runge-Broberg) #33676

PR-URL: #37183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@juanarbol juanarbol juanarbol approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ruyadorno @nodejs-github-bot @MylesBorins @targos @juanarbol @ZYSzys