Document the x509 error codes #37096
Conversation
nodejs-github-bot
added
c++
dcermak
force-pushed
the
add_tls_error_code_docs
branch
from
3557fae
to
6086277
Compare
| // if you modify anything in here, *please* update the respective section in | ||
| // doc/api/tls.md as well |
There was a problem hiding this comment.
I'm not sure this is useful to add a comment here. The chances for this list to be modified is very low – it hasn't changed in the last 8 years, since it was "introduced" in b9a0eb0 (and it's even older than that but you got the point).
| // if you modify anything in here, *please* update the respective section in | |
| // doc/api/tls.md as well |
There was a problem hiding this comment.
Hm, not sure that I agree with you here. Especially as this code is really old, while it is unlikely that it will be changed ever again, if it will, updating the docs will surely be forgotten. But I'm not insisting on keeping this commit.
There was a problem hiding this comment.
OK, let's wait and see if anyone wants to share their thoughts on it. One thing to consider is that doc-only commits tends to be backported faster to LTS release lines.
There was a problem hiding this comment.
Sure, I'm very much open to opinions from contributors as I'm not really familiar with node's development. I'm also not really in a rush to get this backported, so that would be fine by me.
There was a problem hiding this comment.
The comment doesn't hurt I think :-)
dcermak
force-pushed
the
add_tls_error_code_docs
branch
from
40c868d
to
f928f1d
Compare
dcermak
force-pushed
the
add_tls_error_code_docs
branch
from
f928f1d
to
af02457
Compare
dcermak
force-pushed
the
add_tls_error_code_docs
branch
from
b0a532c
to
0c81292
Compare
aduh95
added
the
author ready
Signed-off-by: Dan Čermák <[email protected]> Co-authored-by: Antoine du Hamel <[email protected]> Co-authored-by: James M Snell <[email protected]> PR-URL: nodejs#37096 Fixes: nodejs#29342 Fixes: nodejs#29342 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
aduh95
force-pushed
the
add_tls_error_code_docs
branch
from
0c81292
to
c909481
Compare
|
Landed in c909481 |
Signed-off-by: Dan Čermák <[email protected]> Co-authored-by: Antoine du Hamel <[email protected]> Co-authored-by: James M Snell <[email protected]> PR-URL: #37096 Fixes: #29342 Fixes: #29342 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This fixes: #29342 (was closed unresolved)
Fixes: #29342