Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix dead code in RandomPrimeTraits #37083

Closed
wants to merge 1 commit into from
Closed

src: fix dead code in RandomPrimeTraits #37083

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

params->add and params->rem have already been allocated successfully at these points, and won't be deallocated by the calls to BN_bin2bn, so these branches are effectively dead. Instead, the return value of BN_bin2bn should be checked.

@tniessen tniessen added crypto Issues and PRs related to the crypto subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Jan 26, 2021
@tniessen tniessen requested a review from jasnell January 26, 2021 18:09
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35758/

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 26, 2021
@tniessen
Copy link
Member Author

Landed in 0a993e1, thanks for reviewing.

@tniessen tniessen closed this Jan 29, 2021
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 29, 2021
tniessen added a commit that referenced this pull request Jan 29, 2021
@tniessen
src: fix dead code in RandomPrimeTraits
0a993e1 
PR-URL: #37083
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Feb 2, 2021
@tniessen @targos
src: fix dead code in RandomPrimeTraits
9c831c0 
PR-URL: #37083
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Feb 2, 2021
Merged
@wedataintelligence wedataintelligence mentioned this pull request Jan 12, 2023
Open
This was referenced Jan 12, 2023
Open
Open
@137717unity 137717unity mentioned this pull request Jan 13, 2023
Open
This was referenced Jan 13, 2023
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Apr 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @nodejs-github-bot @jasnell @lpinca @juanarbol @targos