Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: enable object-curly-newline in ESLint rules #37040

Merged
merged 2 commits into from
Jan 27, 2021
Merged

tools: enable object-curly-newline in ESLint rules #37040

merged 2 commits into from
Jan 27, 2021

Commits on Jan 27, 2021

  1. test,doc,lib: adjust object literal newlines for lint rule 

    Before enabling object-curly-newline for our ESLint rules, adjust files
to comply with it.

Refs: https://eslint.org/docs/rules/object-curly-newline

PR-URL: nodejs#37040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
    @Trott
    Trott committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    996b85b View commit details
    Browse the repository at this point in the history

  2. tools: enable object-curly-newline in ESLint rules 

    I saw a PR review comment  about newlines in desructured
assignments, and this would be the rule to enforce these kinds of nits.
Start by just enabling the rule. We can incrementally adjust it to be
more strict.

Refs: https://eslint.org/docs/rules/object-curly-newline
Refs: nodejs#37028 (review)

PR-URL: nodejs#37040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
    @Trott
    Trott committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    3e54870 View commit details
    Browse the repository at this point in the history