-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: remove pull-requests.md preamble #36960
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watilde
approved these changes
Jan 16, 2021
jasnell
approved these changes
Jan 16, 2021
PoojaDurgad
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Jan 18, 2021
tniessen
approved these changes
Jan 18, 2021
jasnell
pushed a commit
that referenced
this pull request
Jan 18, 2021
Refs: nodejs/TSC#864 (comment) PR-URL: #36960 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Landed in a8d8ca3 |
ruyadorno
pushed a commit
that referenced
this pull request
Jan 22, 2021
Refs: nodejs/TSC#864 (comment) PR-URL: #36960 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Jan 25, 2021
Refs: nodejs/TSC#864 (comment) PR-URL: #36960 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Refs: nodejs/TSC#864 (comment) PR-URL: #36960 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
This was referenced Nov 8, 2022
This was referenced Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/TSC#864 (comment)