-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix module.isPreloading documentation #36944
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
module
Issues and PRs related to the module subsystem.
labels
Jan 15, 2021
ExE-Boss
approved these changes
Jan 17, 2021
lpinca
approved these changes
Jan 17, 2021
aduh95
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Jan 17, 2021
Flarna
approved these changes
Jan 18, 2021
jasnell
approved these changes
Jan 18, 2021
Landed in 9d7fb22 |
jasnell
pushed a commit
that referenced
this pull request
Jan 18, 2021
Fixes: #36775 PR-URL: #36944 Refs: #36263 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Jan 18, 2021
Fixes: nodejs#36775 PR-URL: nodejs#36944 Refs: nodejs#36263 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: James M Snell <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Jan 22, 2021
Fixes: #36775 PR-URL: #36944 Refs: #36263 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Jan 25, 2021
Fixes: #36775 PR-URL: #36944 Refs: #36263 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 25, 2021
Fixes: #36775 PR-URL: #36944 Backport-PR-URL: #36988 Refs: #36263 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
added
backported-to-v14.x
and removed
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backport-open-v14.x
labels
Apr 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #36263
Fixes: #36775