-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: add SafeArray
to primordials
and use it for FreeList
#36600
base: main
Are you sure you want to change the base?
Conversation
Run Benchmark on my computer, seems the performance issues still exists.
|
Looks like the benchmark CI crashed: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/783/console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark confirmed very poor performance results…
confidence improvement accuracy (*) (**) (***)
misc/freelist.js n=100000 *** -91.36 % ±3.89% ±5.24% ±6.96%
If I had to guess, I’d say V8 is doing some inlining shenanigans when it detects a By inlining the methods in #37649, I hope to make |
Refs: #36304 (comment)
Refs: #36565
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes