Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add note about uncloneable objects #36534

Closed
wants to merge 1 commit into from
Closed

doc: add note about uncloneable objects #36534

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Dec 15, 2020

Signed-off-by: James M Snell [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels Dec 15, 2020
@jasnell jasnell requested a review from addaleax December 15, 2020 18:59
jasnell
jasnell commented Dec 15, 2020
View reviewed changes
jasnell
jasnell commented Dec 15, 2020
View reviewed changes
Trott
Trott reviewed Dec 16, 2020
View reviewed changes
Trott
Trott reviewed Dec 16, 2020
View reviewed changes
@jasnell jasnell force-pushed the add-note-about-uncloneable-objects branch from 35c274b to f30ceac Compare December 16, 2020 18:29
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 16, 2020
@targos
Copy link
Member

targos commented Dec 21, 2020

This needs a rebase

@targos targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 21, 2020
@jasnell jasnell force-pushed the add-note-about-uncloneable-objects branch from f30ceac to cc177d9 Compare December 31, 2020 18:15
@jasnell
Copy link
Member Author

jasnell commented Dec 31, 2020

Landed in 6ab768e

jasnell added a commit that referenced this pull request Dec 31, 2020
@jasnell
doc: add note about uncloneable objects
6ab768e 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #36534
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@jasnell jasnell closed this Dec 31, 2020
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@jasnell @danielleadams
doc: add note about uncloneable objects
edf8c6d 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #36534
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jasnell @targos @fhinkel @Trott @addaleax @benjamingr @lpinca @nodejs-github-bot