test: skip flaky parts of broadcastchannel test on Windows #36386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fast track, please? My previous attempt to make this test reliable improved things but is insufficient. |
Trott
changed the title
github-actions
bot
removed
the
request-ci
Trott
added
fast-track
|
@nodejs/testing |
|
Windows CI is green, so this is looking good.... |
BethGriggs
approved these changes
Dec 4, 2020
richardlau
approved these changes
Dec 4, 2020
The feature was added recently and is experimental. This will need to be fixed before it can be released as stable (in my opinion at least). But for now, this gets us to a green CI without skipping the parts of the test that are working on Windows. PR-URL: nodejs#36386 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
Landed in d1e4d34 |
danielleadams
pushed a commit
that referenced
this pull request
Dec 7, 2020
The feature was added recently and is experimental. This will need to be fixed before it can be released as stable (in my opinion at least). But for now, this gets us to a green CI without skipping the parts of the test that are working on Windows. PR-URL: #36386 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Dec 8, 2020
The feature was added recently and is experimental. This will need to be fixed before it can be released as stable (in my opinion at least). But for now, this gets us to a green CI without skipping the parts of the test that are working on Windows. PR-URL: nodejs#36386 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature was added recently and is experimental. This will need to be
fixed before it can be released as stable (in my opinion at least). But
for now, this gets us to a green CI without skipping the parts of the
test that are working on Windows.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes