-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error: refactor to use more primordials #36167
Conversation
Commit Queue failed- Loading data for nodejs/node/pull/36167 ✔ Done loading data for nodejs/node/pull/36167 ----------------------------------- PR info ------------------------------------ Title error: refactor to use more primordials (#36167) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:error-prefer-primordials -> nodejs:master Labels author ready, errors Commits 2 - error: refactor to use more primordials - fixup! error: refactor to use more primordials Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/36167 Reviewed-By: James M Snell Reviewed-By: Trivikram Kamat ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36167 Reviewed-By: James M Snell Reviewed-By: Trivikram Kamat -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-11-19T15:29:46Z: https://ci.nodejs.org/job/node-test-pull-request/34468/ - Querying data for job/node-test-pull-request/34468/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Wed, 18 Nov 2020 19:03:39 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/36167#pullrequestreview-534523144 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/36167#pullrequestreview-535143757 -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 36167 From https://github.com/nodejs/node * branch refs/pull/36167/merge -> FETCH_HEAD ✔ Fetched commits as 514f464a600f..86a97e77131b -------------------------------------------------------------------------------- Auto-merging lib/internal/errors.js [master e8aed38623] error: refactor to use more primordials Author: Antoine du Hamel Date: Wed Nov 18 10:57:14 2020 +0100 1 file changed, 5 insertions(+), 3 deletions(-) [master 364cbb53c3] fixup! error: refactor to use more primordials Author: Antoine du Hamel Date: Wed Nov 18 23:04:31 2020 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/3) Rebasing (3/3)https://github.com/nodejs/node/actions/runs/375072234 |
PR-URL: nodejs#36167 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
86a97e7
to
893d8a6
Compare
Landed in 893d8a6 |
PR-URL: #36167 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #36167 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #36167 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes