doc: Updated streams simplified constructor API #3602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
added
doc
| @@ -1384,6 +1388,9 @@ var readable = new stream.Readable({ | |||
| var writable = new stream.Writable({ | |||
| write: function(chunk, encoding, next) { | |||
| // sets this._write under the hood | |||
|
|
|||
| // Optionally with an error | |||
There was a problem hiding this comment.
you mean an error can be optionally passed?
There was a problem hiding this comment.
Yes, that would sound more concise, will update.
|
@trevnorris I have addressed your comments and updated the PR |
|
Thanks much. Anyone from @nodejs/documentation or such mind weighing in? |
|
LGTM!
|
|
LGTM. There are some merge conflicts due to the doc being restructured. I'll fix those up on landing tho. |
jasnell
pushed a commit
that referenced
this pull request
Nov 13, 2015
The examples for implementing the simplified constructor API was missing some details on its correct usages. PR-URL: #3602 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chris Dickinson <[email protected]>
|
Landed in 4270e7f |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2015
The examples for implementing the simplified constructor API was missing some details on its correct usages. PR-URL: #3602 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chris Dickinson <[email protected]>
|
landed in v4.x-staging as bb20abb |
Fishrock123
pushed a commit
that referenced
this pull request
Nov 17, 2015
The examples for implementing the simplified constructor API was missing some details on its correct usages. PR-URL: #3602 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chris Dickinson <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Dec 4, 2015
The examples for implementing the simplified constructor API was missing some details on its correct usages. PR-URL: #3602 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chris Dickinson <[email protected]>
Closed
jasnell
pushed a commit
that referenced
this pull request
Dec 17, 2015
The examples for implementing the simplified constructor API was missing some details on its correct usages. PR-URL: #3602 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chris Dickinson <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Dec 23, 2015
The examples for implementing the simplified constructor API was missing some details on its correct usages. PR-URL: #3602 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chris Dickinson <[email protected]>
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples for implementing the simplified constructor API was missing some details on its correct usages.
I have updated them to reflect this.