Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: support defining event handlers on prototypes #35931

Closed
wants to merge 4 commits into from
Closed

events: support defining event handlers on prototypes #35931

wants to merge 4 commits into from

Conversation

benjamingr
Copy link
Member

This PR allows defining event handlers on prototypes and not just on instances.

Fixes a TODO in the code

CC @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@benjamingr benjamingr added events Issues and PRs related to the events subsystem / EventEmitter. worker Issues and PRs related to Worker support. labels Nov 2, 2020
@benjamingr benjamingr requested review from watilde, addaleax and jasnell and removed request for addaleax and watilde November 2, 2020 21:04
@benjamingr
Copy link
Member Author

I am also not sure about semver-ness. I doubt anyone was relying on the current behaviour but 🤷‍♂️

@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34024/

aduh95
aduh95 reviewed Nov 2, 2020
View reviewed changes
lib/internal/event_target.js Outdated Show resolved Hide resolved
@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34031/

aduh95
aduh95 approved these changes Nov 3, 2020
View reviewed changes
test/parallel/test-eventtarget.js Outdated
@@ -12,7 +12,7 @@ const {
ok,
deepStrictEqual,
strictEqual,
throws,
throws
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this change seems unnecessary

Suggested change
throws
throws,

@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34054/

watilde
watilde approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@watilde watilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34057/

Trott
Trott approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending rebase to resolve conflicts

@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2020
@benjamingr benjamingr mentioned this pull request Nov 5, 2020
Closed
4 tasks
@benjamingr
Copy link
Member Author

@aduh95 awesome, I didn't know that good to know I'll use it in the future it's helpful :]

danielleadams pushed a commit that referenced this pull request Nov 9, 2020
@benjamingr @danielleadams
events: define event handler as enumerable
33e2ee5 
PR-URL: #35931
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
@benjamingr @danielleadams
events: support event handlers on prototypes
ab0eb4f 
PR-URL: #35931
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
@benjamingr @danielleadams
events: define abort on prototype
ff59fcd 
PR-URL: #35931
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
@benjamingr @danielleadams
events: fire handlers in correct oder
9e67372 
PR-URL: #35931
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Nov 9, 2020
Merged
targos pushed a commit to targos/node that referenced this pull request Apr 24, 2021
@benjamingr @targos
events: define event handler as enumerable
eaedd56 
PR-URL: nodejs#35931
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 24, 2021
@benjamingr @targos
events: support event handlers on prototypes
ac9532c 
PR-URL: nodejs#35931
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 24, 2021
@benjamingr @targos
events: define abort on prototype
7b7ce38 
PR-URL: nodejs#35931
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 24, 2021
@benjamingr @targos
events: fire handlers in correct oder
12f23cd 
PR-URL: nodejs#35931
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Apr 24, 2021
Closed
targos pushed a commit to targos/node that referenced this pull request Apr 26, 2021
@benjamingr @targos
events: define event handler as enumerable
668f28e 
PR-URL: nodejs#35931
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 26, 2021
@benjamingr @targos
events: support event handlers on prototypes
285d1ad 
PR-URL: nodejs#35931
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 26, 2021
@benjamingr @targos
events: define abort on prototype
969810c 
PR-URL: nodejs#35931
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 26, 2021
@benjamingr @targos
events: fire handlers in correct oder
a3cdde0 
PR-URL: nodejs#35931
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021
@benjamingr @targos
events: define event handler as enumerable
307bebc 
PR-URL: nodejs#35931
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021
@benjamingr @targos
events: support event handlers on prototypes
902503c 
PR-URL: nodejs#35931
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021
@benjamingr @targos
events: define abort on prototype
6bbd82f 
PR-URL: nodejs#35931
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021
@benjamingr @targos
events: fire handlers in correct oder
7d255e6 
PR-URL: nodejs#35931
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
events: define event handler as enumerable
6e21e82 
PR-URL: #35931
Backport-PR-URL: #38386
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
events: support event handlers on prototypes
bdad1bc 
PR-URL: #35931
Backport-PR-URL: #38386
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
events: define abort on prototype
7c95cfc 
PR-URL: #35931
Backport-PR-URL: #38386
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
events: fire handlers in correct oder
daad521 
PR-URL: #35931
Backport-PR-URL: #38386
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
@extremeheat extremeheat mentioned this pull request Jul 18, 2021
Merged
This was referenced Nov 24, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic left review comments

@aduh95 aduh95 aduh95 approved these changes

@watilde watilde watilde approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
events Issues and PRs related to the events subsystem / EventEmitter. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@benjamingr @nodejs-github-bot @aduh95 @domenic @Trott @addaleax @watilde @targos