doc: move all TLS-PSK documentation to its section #35717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
I've also reworded some things and removed the phrase "identity must use UTF-8 encoding" since it doesn't seem to make sense, |
Trott
reviewed
Oct 20, 2020
Trott
reviewed
Oct 20, 2020
Trott
approved these changes
Oct 20, 2020
aymen94
approved these changes
Oct 21, 2020
|
@mildsunrise can you please address the comments so this can land? |
My comments are non-blocking, so it's really just @lundibundi's one suggestion (which might also be non-blocking)? |
Mifrill
reviewed
Dec 14, 2023
Mifrill
reviewed
Dec 14, 2023
|
This needs a rebase. |
aduh95
added
the
author ready
|
Landed in c3358aa |
targos
pushed a commit
that referenced
this pull request
Jun 1, 2024
PR-URL: #35717 Reviewed-By: Rich Trott <[email protected]>
Merged
EliphazBouye
pushed a commit
to EliphazBouye/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#35717 Reviewed-By: Rich Trott <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#35717 Reviewed-By: Rich Trott <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #35717 Reviewed-By: Rich Trott <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #35717 Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation on PSK is scattered in various places, I suggest we put it all in its section (and link to there).
PSK is a marginal feature and must be used with care, so I think it's better this way, and we avoid cluttering the
optionssection with really long option entries.@nodejs/documentation @nodejs/crypto