Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: refine module type mismatch error cases #35426

Closed
wants to merge 1 commit into from
Closed

module: refine module type mismatch error cases #35426

wants to merge 1 commit into from

Conversation

guybedford
Copy link
Contributor

This fixes up the error message in the case when importing a CJS module that contains ES module syntax.

Specifically, hiding the cjs-module-lexer parse failure message, and also then surfacing the warning context that informs the user about the "type" and ".mjs" format indicators to be able to correct the underlying issue.

Before this change:

import { name } from './module.cjs';

where module.cjs contains export / import syntax so is not valid CommonJS, would output as per the error in #35425.

With this change, we now get an error like:

(node:7249) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
/home/guybedford/Projects/node/test/fixtures/es-modules/invalid-cjs.js:1
export var name = 5;
^^^^^^

SyntaxError: Unexpected token 'export'
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the esm Issues and PRs related to the ECMAScript Modules implementation. label Sep 30, 2020
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@guybedford guybedford mentioned this pull request Sep 30, 2020
Closed
@guybedford
Copy link
Contributor Author

Ping @nodejs/modules-active-members for review. It could even be worth fast-tracking this.

mcollina
mcollina approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and +1 to fast-track

MylesBorins
MylesBorins approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins MylesBorins added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 30, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33306/

guybedford added a commit that referenced this pull request Oct 1, 2020
@guybedford
module: refine module type mismatch error cases
726143e 
PR-URL: #35426
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@guybedford
Copy link
Contributor Author

Landed in 726143e.

@guybedford guybedford closed this Oct 1, 2020
@guybedford guybedford mentioned this pull request Oct 1, 2020
Closed
4 tasks
guybedford added a commit to guybedford/node that referenced this pull request Oct 1, 2020
@guybedford
module: refine module type mismatch error cases
0708932 
PR-URL: nodejs#35426
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
codebytere pushed a commit that referenced this pull request Oct 4, 2020
@guybedford @codebytere
module: refine module type mismatch error cases
5357a05 
PR-URL: #35426
Backport-PR-URL: #35405
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@codebytere codebytere mentioned this pull request Oct 4, 2020
Merged
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
@guybedford @danielleadams
module: refine module type mismatch error cases
f23a0e2 
PR-URL: #35426
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 6, 2020
Merged
codebytere added a commit to electron/electron that referenced this pull request Oct 8, 2020
@codebytere
Fixup fs override patch
111355a 
nodejs/node#35426
@KilianKilmister KilianKilmister mentioned this pull request Oct 11, 2020
Open
4 tasks
aduh95 pushed a commit to aduh95/node that referenced this pull request Oct 23, 2020
@guybedford @aduh95
module: refine module type mismatch error cases
ade34f3 
PR-URL: nodejs#35426
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 23, 2020
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@guybedford @MylesBorins
module: refine module type mismatch error cases
be3dfa6 
Backport-PR-URL: #35757
PR-URL: #35426
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@guybedford @MylesBorins
module: refine module type mismatch error cases
6ca8fb5 
Backport-PR-URL: #35757
PR-URL: #35426
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@guybedford @joesepi
module: refine module type mismatch error cases
11cd26a 
PR-URL: nodejs#35426
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

@bmeck bmeck bmeck approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@guybedford @nodejs-github-bot @mcollina @bmeck @MylesBorins @aduh95