net: give better error messages #35
Conversation
| @@ -0,0 +1,46 @@ | |||
| // Copyright Joyent, Inc. and other Node contributors. | |||
evanlucas
force-pushed
the
net-error-messages
branch
from
8534fb2
to
85ec66f
Compare
|
@jonathanong Good point. Removed. |
|
Thanks @evanlucas That 1 less thing I have to do this weekend. 😄 I had a brief look yesterday and there were other areas that used this same error logic, Socket being one of them. Have you had a look through there as well? |
|
I have not. I would be more than happy to though. |
|
It's unfortunate that we don't have a solid perf suite yet to assess these kinds of changes! |
|
For sure. That was a concern when I had opened a PR on the node repo. |
| var ex = errnoException(err, 'listen'); | ||
| var details, additions; | ||
| if (port > 0) { | ||
| details = util.format('%s:%s', address, port); |
There was a problem hiding this comment.
I think this whole chunk could be moved to a function.
|
@evanlucas looks really promising! Left some comments. @rvagg I'm not sure how this even could be benchmarked, and what would these numbers mean. But technically it should be possible. @evanlucas do you think you may create some benchmark that will simulate EPIPE or whatever in a large quantities? |
|
Let me see what I can come up with on the benchmark |
| @@ -755,7 +755,8 @@ function afterWrite(status, handle, req, err) { | |||
| } | |||
|
|
|||
| if (status < 0) { | |||
| var ex = errnoException(status, 'write', err); | |||
| err = util.format('%s %s:%s', err, req.address, req.port); | |||
There was a problem hiding this comment.
Using simple string concatenation here should be significantly faster than calling util.format(). I/O errors are the exceptional case, of course, but in a large scale applications, they probably happen frequently enough to merit optimizing for.
|
Ok, I broke it out into a function and am now setting the properties in code. The syscall is now only called in the event an error actually occurs and I went ahead and fixed up the tests as requested. As far as the benchmark goes, would that need to go in the benchmark directory? I have not been able to run the current net benchmark tests...they just hang, so wasn't sure exactly where you wanted me to put the new benchmark test. Thanks! |
rvagg
force-pushed
the
v0.12
branch
4 times, most recently
from
d7e65ff
to
185d11c
Compare
| @@ -817,28 +836,46 @@ function connect(self, address, port, addressType, localAddress, localPort) { | |||
| err = bind(localAddress, localPort); | |||
|
|
|||
| if (err) { | |||
| self._destroy(errnoException(err, 'bind')); | |||
| var ex = detailedException(err, 'bind', address, port); | |||
There was a problem hiding this comment.
Did you mean localAddress and localPort because of bind(localAddress, localPort)? You're not passing address and port variables to that call.
|
Ok, went ahead and updated those tests. I also fixed the error message to include the local port and address on bind error as pointed out by @xaka. Thanks! |
|
LGTM. Can you squash it into a single commit with a nice commit log? If you haven't seen it, CONTRIBUTING.md has an example of a good commit log. Can I get one more LGTM from another committer? Thanks. |
Add address and/or port to errors where applicable for better reporting. In the event the local address and port are accessible, it will also add those to the error message. See nodejs/node-v0.x-archive#7005
evanlucas
force-pushed
the
net-error-messages
branch
from
a280778
to
00443c0
Compare
|
I squashed it into one commit with a better commit log. Thanks |
Add address and/or port to errors where applicable for better reporting.
See nodejs/node-v0.x-archive#7005 and #16