Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,doc: add missing uv_setup_args() calls #34751

Closed
wants to merge 1 commit into from
Closed

test,doc: add missing uv_setup_args() calls #34751

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 12, 2020

libuv 1.39.0 will begin requiring uv_setup_args() to be called
before attempting to access the process title. This commit adds
uv_setup_args() calls that were missing in order for the test
suite to pass (and updates the documentation).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@cjihrig
test,doc: add missing uv_setup_args() calls
c2ae8ee 
libuv 1.39.0 will begin requiring uv_setup_args() to be called
before attempting to access the process title. This commit adds
uv_setup_args() calls that were missing in order for the test
suite to pass (and updates the documentation).
@cjihrig cjihrig mentioned this pull request Aug 12, 2020
Merged
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 13, 2020 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32760/ 💚

@vtjnash vtjnash mentioned this pull request Aug 14, 2020
Closed
@cjihrig cjihrig mentioned this pull request Aug 14, 2020
Closed
@Trott
Copy link
Member

Trott commented Aug 14, 2020

Landed in 1e59f31

@Trott Trott closed this Aug 14, 2020
Trott pushed a commit that referenced this pull request Aug 14, 2020
@cjihrig @Trott
test,doc: add missing uv_setup_args() calls
1e59f31 
libuv 1.39.0 will begin requiring uv_setup_args() to be called
before attempting to access the process title. This commit adds
uv_setup_args() calls that were missing in order for the test
suite to pass (and updates the documentation).

PR-URL: #34751
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@cjihrig cjihrig deleted the setup-args branch August 15, 2020 00:16
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
@cjihrig @MylesBorins
test,doc: add missing uv_setup_args() calls
48224e4 
libuv 1.39.0 will begin requiring uv_setup_args() to be called
before attempting to access the process title. This commit adds
uv_setup_args() calls that were missing in order for the test
suite to pass (and updates the documentation).

PR-URL: #34751
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@cjihrig @BethGriggs
test,doc: add missing uv_setup_args() calls
5009d82 
libuv 1.39.0 will begin requiring uv_setup_args() to be called
before attempting to access the process title. This commit adds
uv_setup_args() calls that were missing in order for the test
suite to pass (and updates the documentation).

PR-URL: #34751
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@addaleax addaleax mentioned this pull request Sep 23, 2020
Closed
4 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Sep 23, 2020
@cjihrig @addaleax
test,doc: add missing uv_setup_args() calls
fa4439d 
libuv 1.39.0 will begin requiring uv_setup_args() to be called
before attempting to access the process title. This commit adds
uv_setup_args() calls that were missing in order for the test
suite to pass (and updates the documentation).

PR-URL: nodejs#34751
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@addaleax addaleax added backport-open-v12.x libuv Issues and PRs related to the libuv dependency or the uv binding. labels Sep 23, 2020
addaleax pushed a commit that referenced this pull request Sep 23, 2020
@cjihrig @addaleax
test,doc: add missing uv_setup_args() calls
26ede7f 
libuv 1.39.0 will begin requiring uv_setup_args() to be called
before attempting to access the process title. This commit adds
uv_setup_args() calls that were missing in order for the test
suite to pass (and updates the documentation).

Backport-PR-URL: #35241
PR-URL: #34751
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
addaleax added a commit to addaleax/node that referenced this pull request Oct 4, 2020
@addaleax
tools: add missing uv_setup_argv() calls
e8a56e7 
Refs: nodejs#34751
@addaleax addaleax mentioned this pull request Oct 4, 2020
Closed
2 tasks
nodejs-github-bot pushed a commit that referenced this pull request Oct 6, 2020
@addaleax @nodejs-github-bot
tools: add missing uv_setup_argv() calls
b5490d0 
Refs: #34751

PR-URL: #35491
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
@addaleax @danielleadams
tools: add missing uv_setup_argv() calls
5790c40 
Refs: #34751

PR-URL: #35491
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@addaleax @MylesBorins
tools: add missing uv_setup_argv() calls
df152e4 
Refs: #34751

PR-URL: #35491
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@addaleax @MylesBorins
tools: add missing uv_setup_argv() calls
0955267 
Refs: #34751

PR-URL: #35491
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@addaleax @joesepi
tools: add missing uv_setup_argv() calls
aa94935 
Refs: nodejs#34751

PR-URL: nodejs#35491
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2021
@addaleax @targos
tools: add missing uv_setup_argv() calls
fe4ef1c 
Refs: #34751

PR-URL: #35491
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 1, 2021
@addaleax @Trott
tools: add missing uv_setup_argv() calls
22f9ea6 
Refs: nodejs#34751

PR-URL: nodejs#35491
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@devnexen devnexen devnexen approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
libuv Issues and PRs related to the libuv dependency or the uv binding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @nodejs-github-bot @Trott @devnexen @richardlau @addaleax