Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky http-parser-timeout-reset #34609

Closed
wants to merge 1 commit into from
Closed

test: fix flaky http-parser-timeout-reset #34609

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 3, 2020

Refs: #34578 (comment)

Tries to fix a test.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag ronag added the http Issues or PRs related to the http subsystem. label Aug 3, 2020
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4196

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 3, 2020
@ronag
Copy link
Member Author

ronag commented Aug 3, 2020

@richardlau

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32605/

@richardlau richardlau added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Aug 3, 2020
@MylesBorins
Copy link
Contributor

we should fast track

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 3, 2020
MylesBorins
MylesBorins approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32611/

@MylesBorins
Copy link
Contributor

Landed in 8d8090b

@MylesBorins MylesBorins closed this Aug 3, 2020
MylesBorins pushed a commit that referenced this pull request Aug 3, 2020
@ronag @MylesBorins
test: fix flaky http-parser-timeout-reset
8d8090b 
Refs: #34578 (comment)

PR-URL: #34609
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
codebytere pushed a commit that referenced this pull request Aug 6, 2020
@ronag @codebytere
test: fix flaky http-parser-timeout-reset
a340587 
Refs: #34578 (comment)

PR-URL: #34609
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@codebytere codebytere mentioned this pull request Aug 10, 2020
Merged
codebytere pushed a commit that referenced this pull request Aug 11, 2020
@ronag @codebytere
test: fix flaky http-parser-timeout-reset
283f5c3 
Refs: #34578 (comment)

PR-URL: #34609
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@Flarna Flarna mentioned this pull request Oct 26, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronag @nodejs-github-bot @MylesBorins @richardlau @Flarna