test: skip test-dns-ipv6.js if ipv6 is unavailable #3444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,6 +40,11 @@ function checkWrap(req) { | |||
| assert.ok(typeof req === 'object'); | |||
| } | |||
|
|
|||
| if (!common.hasIPv6) { | |||
| console.log('1..0 # Skipped: ipv6 part of test, no IPv6 support'); | |||
There was a problem hiding this comment.
the entire test is ipv6. You might want to make copy specify the entire test has failed
|
Issue number: #3443 |
|
LGTM |
| @@ -40,6 +40,11 @@ function checkWrap(req) { | |||
| assert.ok(typeof req === 'object'); | |||
| } | |||
|
|
|||
| if (!common.hasIPv6) { | |||
There was a problem hiding this comment.
LGTM, but couldn't you move this a little closer to the top of the file?
There was a problem hiding this comment.
if it is put ahead of some of the variable declarations in the file then the process exit event won't pass.
There was a problem hiding this comment.
at least needs to be below these
https://github.com/john-yan/node/blob/master/test/internet/test-dns-ipv6.js#L10-L13
mscdex
added
dns
|
LGTM |
1 similar comment
|
LGTM |
| @@ -12,6 +12,11 @@ var expected = 0, | |||
| running = false, | |||
| queue = []; | |||
|
|
|||
| if (!common.hasIPv6) { | |||
| console.log('1..0 # Skipped this test, no IPv6 support'); | |||
There was a problem hiding this comment.
One last nit, the style we use is 1..0 # Skipped: :)
jasnell
pushed a commit
that referenced
this pull request
Oct 20, 2015
Test should be skipped if ipv6 is unavailable on the running system. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #3444
|
Landed in a1886cf |
rvagg
pushed a commit
that referenced
this pull request
Oct 21, 2015
Test should be skipped if ipv6 is unavailable on the running system. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #3444
jasnell
pushed a commit
that referenced
this pull request
Oct 26, 2015
Test should be skipped if ipv6 is unavailable on the running system. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #3444
|
Landed in v4.x-staging in 49549c9 |
jasnell
pushed a commit
that referenced
this pull request
Oct 29, 2015
Test should be skipped if ipv6 is unavailable on the running system. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #3444
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test should be skipped if ipv6 is unavailable on the running system.