test: Verify request payload is uploaded consistently

[awwright]

This adds several HTTP tests testing for the behavior identified in #27880:

• test-http-27880-bug.js — shows how, if you make a DELETE request with a payload, the payload will actually be written to the server where a second HTTP/1.1 request is expected; if the payload is a valid HTTP message, it will be interpreted as a second request by the server. (But the first request is sent with Connection: close so shouldn't the server close the connection by this point?)
• test-http-27880-chunked.js — tests that the default behavior for ClientRequest#write should be a chunked encoding.
• test-http-27880-content-length.js — tests that the default behavior for ClientRequest#end should be a standard message, with an automatically computed Content-Length header.
• test-http-27880-empty.js — tests that the default behavior for ClientRequest#end should have no payload headers if there's no response body

Naming for the test files will probably need to be reconsidered; suggestions welcome.

Refs: #27880

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included

• commit message follows commit guidelines

[aduh95]

@awwright there are some failing tests which keep this from landing. Do you still want to work on this?

[github-actions]

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

[awwright]

@aduh95 Those failed tests are bugs in the HTTP implementation that need to be fixed. However I'm not sure what the process is for doing this, exactly.

[aduh95]

I think the process is to move those tests to test/known_issues.

[awwright]

@aduh95 I rebased and moved the tests, I'm hoping that is sufficient?

[aduh95]

Regarding the naming of the file, what about:

• test-http-request-method-delete-payload.js
• test-http-clientrequest-write-chunked.js
• test-http-clientrequest-end-contentlength.js
• test-http-clientrequest-end-empty-response-body.js

[awwright]

That seems reasonable.

It's not obvious in how the files are written, but I'm trying to test the behavior in both directions, too. I actually forget off-hand if the bug is in requests only, or both request and responses.

[aduh95]

@awwright Do you want to rename those files so we can move forward with this?

[github-actions]

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

[github-actions]

Closing this because it has stalled. Feel free to reopen if this PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.

[ronag]

@aduh95 @dnlup @awwright any chance of revival?

[ronag]

@nodejs/http

[dnlup]

I am a little swamped atm. I don't think I am going to be able to work on it now. Sorry.

[awwright]

What else exactly does this need? Can we not merge a test that's showing an actual, live bug?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59125/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59142/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59176/

[aduh95]

Landed in d4e365f