Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.x] deps: V8: backport cd21f71f9cb5 #33862

Closed
wants to merge 1 commit into from

Commits on Jun 13, 2020

  1. deps: V8: backport cd21f71f9cb5

    Original commit message:
    
        [parser] Validate destructuring assignment pattern in correct classifier
    
        Previously we'd first accumulate errors to the parent and validate the
        destructuring pattern in the parent. In the case of ParseArguments this
        will invalidly propagate binding pattern errors from one argument to the
        next. The reason why ParseArguments keeps track of binding pattern errors
        is because it could also be used to parse async arrow function parameters.
        If we see async(a,b) we don't yet know whether this is the head of an
        async arrow function, or a call to async with arguments a and b.
    
        Bug: v8:8241
        Change-Id: I670ab9a9c6f2e0bee399808b02a465ae1afa7c3f
        Reviewed-on: https://chromium-review.googlesource.com/c/1296229
        Commit-Queue: Toon Verwaest <[email protected]>
        Reviewed-by: Marja Hölttä <[email protected]>
        Cr-Commit-Position: refs/heads/master@{#56887}
    
    Refs: v8/v8@cd21f71
    Fixes: nodejs#23142
    targos committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    334f63b View commit details
    Browse the repository at this point in the history