Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove shell dollar signs without output #33692

Closed
wants to merge 1 commit into from
Closed

doc: remove shell dollar signs without output #33692

wants to merge 1 commit into from

Conversation

nschonni
Copy link
Member

@nschonni nschonni commented Jun 2, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 2, 2020
@nschonni nschonni changed the title shell-dollar-fix doc: remove shell dollar signs without output Jun 2, 2020
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 2, 2020
Trott pushed a commit that referenced this pull request Jun 4, 2020
@nschonni @Trott
doc: remove shell dollar signs without output
6e8709d 
Related to nodejs/remark-preset-lint-node#94

PR-URL: #33692
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented Jun 4, 2020

Landed in 6e8709d

@Trott Trott closed this Jun 4, 2020
@nschonni nschonni deleted the shell-dollar-fix branch June 4, 2020 14:42
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@nschonni @codebytere
doc: remove shell dollar signs without output
16b6981 
Related to nodejs/remark-preset-lint-node#94

PR-URL: #33692
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@nschonni @codebytere
doc: remove shell dollar signs without output
4a8d714 
Related to nodejs/remark-preset-lint-node#94

PR-URL: #33692
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Jul 9, 2020
@nschonni @codebytere
doc: remove shell dollar signs without output
35cee03 
Related to nodejs/remark-preset-lint-node#94

PR-URL: #33692
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@nschonni @codebytere
doc: remove shell dollar signs without output
067578a 
Related to nodejs/remark-preset-lint-node#94

PR-URL: #33692
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHeer MrHeer MrHeer approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nschonni @Trott @jasnell @lpinca @targos @cjihrig @BridgeAR @MrHeer @nodejs-github-bot