build: add --v8-lite-mode flag #33541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
addaleax
approved these changes
May 24, 2020
cjihrig
approved these changes
May 24, 2020
richardlau
approved these changes
May 24, 2020
bnoordhuis
approved these changes
May 25, 2020
There was a problem hiding this comment.
Not opposed, just want to point out that a "lite mode" build is identical to starting node with --lite_mode --jitless (and --lite_mode is a no-op nowadays, only --jitless does something.)
In other words, this PR is shorthand for ./configure --v8-options="--lite_mode --jitless" but with a better help text. :-)
jasnell
approved these changes
May 25, 2020
BridgeAR
added
the
author ready
|
CI: https://ci.nodejs.org/job/node-test-pull-request/31589/ 💛 (known flake: parallel/test-http2-reset-flood) |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 30, 2020
PR-URL: nodejs#33541 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 01c4455 |
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #33541 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33541 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jul 8, 2020
PR-URL: #33541 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change just exposes the V8 compilation option for Lite Mode (see https://v8.dev/blog/v8-lite) which also implies jitless (see https://v8.dev/blog/jitless) when set.
It should be useful in some niche scenarios like compiling for memory constrained platforms or those that don't allow for just in time compilation (like iOS).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThe tests do not pass when compiling with this flag activated due to V8 not supporting webassebly in lite mode. The normal build is unaffected and the tests pass.
No additional tests or benchmarks added. The V8 team has an extensive overview of the lite mode.
I'm not sure if the flag needs to be added to documentation. It's pretty niche and other similar flags don't seem to be documented as far as I can tell.