-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: mark test-dgram-multicast-ssmv6-multi-process flaky #33498
Conversation
refs: nodejs#32946 Mark this test as flaky on linux Ive used sequential.status as a template for this file
0a62fca
to
eaef98e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. Since this is in internet
this must be failing during the daily runs? In which case you may need to check how that job is treating flaky tests (i.e. is --flaky-tests=
being set for the test harness).
the daily triggers this through https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/configure, and it looks good
|
I propose fast-tracking if CI is green for the PR. |
refs: #32946 Mark this test as flaky on linux Ive used sequential.status as a template for this file PR-URL: #33498 Refs: #32946 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Landed in e14786f |
refs: #32946 Mark this test as flaky on linux Ive used sequential.status as a template for this file PR-URL: #33498 Refs: #32946 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
refs: #32946 Mark this test as flaky on linux Ive used sequential.status as a template for this file PR-URL: #33498 Refs: #32946 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
refs: #32946 Mark this test as flaky on linux Ive used sequential.status as a template for this file PR-URL: #33498 Refs: #32946 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
refs: #32946
Mark this test as flaky on linux as its been failing
test-commit-custom-suites-freestyle
for a whileIve used sequential.status as a template for this file.