Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use enum for refed flag on native immediates #33444

Closed
wants to merge 1 commit into from
Closed

src: use enum for refed flag on native immediates #33444

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Refs: #33320 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels May 17, 2020
@addaleax addaleax requested a review from jasnell May 17, 2020 05:15
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31361/

@himself65 himself65 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 17, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31362/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31363/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31367/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31422/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31440/

jasnell pushed a commit that referenced this pull request May 22, 2020
@addaleax @jasnell
src: use enum for refed flag on native immediates
b6b82cb 
Refs: #33320 (comment)

PR-URL: #33444
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@jasnell
Copy link
Member

jasnell commented May 22, 2020

Landed in b6b82cb

@jasnell jasnell closed this May 22, 2020
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@addaleax @codebytere
src: use enum for refed flag on native immediates
7d1d00f 
Refs: #33320 (comment)

PR-URL: #33444
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
@codebytere
Copy link
Member

@addaleax should this go back to v12.x? I see a small nest of conflicts.

@addaleax addaleax deleted the refed-explicit branch July 8, 2020 20:30
@addaleax addaleax mentioned this pull request Jul 8, 2020
Closed
4 tasks
addaleax added a commit to addaleax/node that referenced this pull request Jul 8, 2020
@addaleax
src: use enum for refed flag on native immediates
4b2a048 
Refs: nodejs#33320 (comment)

PR-URL: nodejs#33444
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
addaleax added a commit that referenced this pull request Sep 23, 2020
@addaleax
src: use enum for refed flag on native immediates
1d3638b 
Refs: #33320 (comment)

PR-URL: #33444
Backport-PR-URL: #34263
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
This was referenced May 22, 2023
Open
Open
Open
@137717unity 137717unity mentioned this pull request May 22, 2023
Open
@snyk-bot snyk-bot mentioned this pull request May 23, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request May 24, 2023
Open
@baby636 baby636 mentioned this pull request May 24, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Nov 25, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Nov 28, 2023
Open
@baby636 baby636 mentioned this pull request Nov 28, 2023
Open
@ron-a20 ron-a20 mentioned this pull request Dec 19, 2023
Open
@137717unity 137717unity mentioned this pull request Dec 19, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Dec 19, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Dec 19, 2023
Open
@baby636 baby636 mentioned this pull request Dec 20, 2023
Open
@137717unity 137717unity mentioned this pull request Apr 14, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Apr 14, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Apr 14, 2024
Open
@molllyn1 molllyn1 mentioned this pull request Apr 14, 2024
Open
@kissofire kissofire mentioned this pull request Apr 14, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Apr 14, 2024
Open
@baby636 baby636 mentioned this pull request Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 approved these changes

@devnexen devnexen devnexen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@addaleax @nodejs-github-bot @jasnell @codebytere @bnoordhuis @cjihrig @devnexen @himself65