doc: show keylen in pbkdf2 as a byte length #3334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
doc
|
LGTM |
|
@calebboyd Your git signing email is set to You can change this by doing: git config --global user.email "[email protected]"
git commit --amend --reset-author --no-editAnd then force-pushing to this branch. :) |
Ensure that keylen for pbkdf2 is documented as a length of bytes and not bits
|
Aha, Thanks. I edited it in github, fixed. |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Oct 19, 2015
Ensure that keylen for pbkdf2 is documented as a length of bytes and not bits. PR-URL: nodejs#3334 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
|
Thanks! Landed in ff8fa51 :) |
rvagg
pushed a commit
that referenced
this pull request
Oct 21, 2015
Ensure that keylen for pbkdf2 is documented as a length of bytes and not bits. PR-URL: #3334 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Oct 26, 2015
Ensure that keylen for pbkdf2 is documented as a length of bytes and not bits. PR-URL: #3334 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
|
landed in v4.x-staging in 925953d |
jasnell
pushed a commit
that referenced
this pull request
Oct 29, 2015
Ensure that keylen for pbkdf2 is documented as a length of bytes and not bits. PR-URL: #3334 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
This was referenced Feb 20, 2022
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
This was referenced May 13, 2024
This was referenced May 22, 2024
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that keylen for pbkdf2 is documented as a length of bytes and not bits