Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: mark assert.CallTracker experimental #33124

Closed

Conversation

BridgeAR
Copy link
Member

Some details might still change and it would be good to get feedback
from users before we mark this as stable.

It might for example be good to rework the stack property.

Signed-off-by: Ruben Bridgewater [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Some details might still change and it would be good to get feedback
from users before we mark this as stable.

Signed-off-by: Ruben Bridgewater <[email protected]>
@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Apr 28, 2020
@jasnell
Copy link
Member

jasnell commented Apr 28, 2020

Won't block this but I don't see it as strictly necessary. If additional useful changes are to be made, then let's identify those and get them in. It's still brand new API that very few are no one is using yet because it has not yet gone out in a release.

Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this is a very good idea. My big concern with pretty much all new APIS is that we may find that we've made an API design mistake. Once people start using it, it may become apparent that there is a more ergonomic way to do things. And I'm also often concerned that we may not name APIs the best we can. Let's leave ourselves a little wiggle room for a few releases. If it goes out as Experimental in, say, 14.2.0, we can always remove Experimental in a later 14.x release.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 3, 2020
targos pushed a commit that referenced this pull request May 4, 2020
Some details might still change and it would be good to get feedback
from users before we mark this as stable.

Signed-off-by: Ruben Bridgewater <[email protected]>

PR-URL: #33124
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos
Copy link
Member

targos commented May 4, 2020

Landed in c81e5f6

@targos targos closed this May 4, 2020
targos pushed a commit that referenced this pull request May 4, 2020
Some details might still change and it would be good to get feedback
from users before we mark this as stable.

Signed-off-by: Ruben Bridgewater <[email protected]>

PR-URL: #33124
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos targos mentioned this pull request May 4, 2020
@targos targos added baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v12.x labels May 7, 2020
@codebytere
Copy link
Member

This is blocked until assert.CallTracker itself is backported to v12.x i believe?

@addaleax addaleax removed backport-blocked-v12.x baking-for-lts PRs that need to wait before landing in a LTS release. labels Sep 23, 2020
addaleax pushed a commit that referenced this pull request Sep 23, 2020
Some details might still change and it would be good to get feedback
from users before we mark this as stable.

Signed-off-by: Ruben Bridgewater <[email protected]>

PR-URL: #33124
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants