stream: remove unused _transformState #33105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_transformState is no longer used since Transform was simplified. Refs: nodejs#32763
|
@nodejs/streams |
|
I wonder if |
lpinca
approved these changes
Apr 28, 2020
mcollina
reviewed
Apr 28, 2020
|
Did #32763 land on v14? |
|
Oy, I wish I had caught #32763 before it landed. Even tho |
|
@jasnell: I'll open a separate PR for runtime deprecation against v14. Can it still land there though? |
|
The @nodejs/tsc will have to decide. We've done it before. |
4 tasks
|
@mcollina: Was that lgtm an approve? |
ronag
added
the
author ready
|
Landed in e10e292 |
ronag
added a commit
that referenced
this pull request
Apr 30, 2020
_transformState is no longer used since Transform was simplified. Refs: #32763 PR-URL: #33105 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Jun 28, 2020
Transform._transformState is removed in future version as part of a refactoring. Refs: nodejs#32763 Refs: nodejs#33105 (comment)
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Transform._transformState is removed in future version as part of a refactoring. Refs: #32763 Refs: #33105 (comment) Backport-PR-URL: #33126 PR-URL: #32763
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Transform._transformState is removed in future version as part of a refactoring. Refs: #32763 Refs: #33105 (comment) Backport-PR-URL: #33126 PR-URL: #32763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_transformState is no longer used since Transform was simplified.
Refs: #32763
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes