test: update test-npm to use absolute paths for tmp/cache/prefix #3309
Conversation
mscdex
added
npm
| @@ -24,9 +24,9 @@ rm -rf npm-cache npm-tmp npm-prefix | |||
| mkdir npm-cache npm-tmp npm-prefix | |||
|
|
|||
| # set some npm env varibles to point to our new temporary folders | |||
There was a problem hiding this comment.
Could you also s/varibles/variables while you're at it? :D
|
lgtm pending @Fishrock123's request |
|
Ping @iarna LGTM, but the title exceeds 50 characters. Also the commit prefix should probably be These are minor nits I can fix on landing if need be, though. :) |
|
Landed in f5445db with the above nits fixed |
Updated test-npm to use absolute paths for tmp/cache/prefix PR-URL: #3309 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Updated test-npm to use absolute paths for tmp/cache/prefix PR-URL: #3309 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
|
should this be added to LTS? /cc @jasnell |
|
It could be, but I'm not worried about this being necessary in npm@2. |
|
fair enough. I guess we can hold off on this assuming npm3 will not be backported |
|
@thealphanerd npm @ 3 is a breaking change. :) |
|
Don't see a pressing need to get this into lts
|
This gives npm absolute paths to use for its cache, prefix and tmp folders. Using relative paths seems to work, but makes me feel veeery edgy, as we do sometimes run subshells with copies of npm and we do sometimes change the working directory in tests. It seems to me that using relative paths here is just asking for really hard to track down trouble.
r: @Fishrock123
r: @chrisdickinson