Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: add stack size resource limit option #33085

Closed
wants to merge 2 commits into from
Closed

worker: add stack size resource limit option #33085

wants to merge 2 commits into from

Commits on Apr 27, 2020

  1. worker: unify custom error creation 

    Mostly, this introduces a pattern that makes sure that if a custom
error is reported, `stopped_` will be set to `true` correctly in
every cast, which was previously missing for the
`NewContext().IsEmpty()` case (which led to a hard crash from the
`Worker` destructor).

This also leaves TODO comments for a few cases in which
`ERR_WORKER_OUT_OF_MEMORY` was not used in accordance with the
documentation for that error code (or according to its intention).
Fixing that is semver-major.
    @addaleax
    addaleax committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    293934f View commit details
    Browse the repository at this point in the history

  2. worker: add stack size resource limit option 

    Add `stackSizeMb` to the `resourceLimit` option group.

Refs: nodejs#31593 (comment)
    @addaleax
    addaleax committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    f1905e8 View commit details
    Browse the repository at this point in the history