Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: flaky test-stdout-close-catch on freebsd #32849

Closed
wants to merge 2 commits into from
Closed

test: flaky test-stdout-close-catch on freebsd #32849

wants to merge 2 commits into from

Conversation

sam-github
Copy link
Contributor

Refs: #28803

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 14, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30732/

@sam-github sam-github added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 14, 2020
@sam-github
Copy link
Contributor Author

can I fast track?

@sam-github
test: flaky test-stdout-close-catch on freebsd
d33f75b 
Refs: nodejs#28803
@sam-github
test: mark flaky on freebsd
a4c4087 
Test name test-worker-message-port-message-before-close is too long for
a commit message description.

Refs: nodejs#31280
@sam-github sam-github force-pushed the flaky-test-stdout-close-catch branch from 5b413a5 to a4c4087 Compare April 17, 2020 21:50
juanarbol
juanarbol approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Apr 27, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31041/

addaleax pushed a commit that referenced this pull request Apr 28, 2020
@sam-github @addaleax
test: flaky test-stdout-close-catch on freebsd
22192fc 
Refs: #28803

PR-URL: #32849
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Apr 28, 2020
@sam-github @addaleax
test: mark test flaky on freebsd
8e956f4 
Test name test-worker-message-port-message-before-close is too long for
a commit message description.

Refs: #31280

PR-URL: #32849
Refs: #28803
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@addaleax
Copy link
Member

Landed in 1d0b249...8e956f4

@addaleax addaleax closed this Apr 28, 2020
targos pushed a commit that referenced this pull request May 4, 2020
@sam-github @targos
test: flaky test-stdout-close-catch on freebsd
aced1f5 
Refs: #28803

PR-URL: #32849
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request May 4, 2020
@sam-github @targos
test: mark test flaky on freebsd
f79ef96 
Test name test-worker-message-port-message-before-close is too long for
a commit message description.

Refs: #31280

PR-URL: #32849
Refs: #28803
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request May 4, 2020
Merged
targos pushed a commit that referenced this pull request May 7, 2020
@sam-github @targos
test: flaky test-stdout-close-catch on freebsd
086357e 
Refs: #28803

PR-URL: #32849
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request May 7, 2020
@sam-github @targos
test: mark test flaky on freebsd
fd7db6a 
Test name test-worker-message-port-message-before-close is too long for
a commit message description.

Refs: #31280

PR-URL: #32849
Refs: #28803
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request May 7, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@sam-github @targos
test: flaky test-stdout-close-catch on freebsd
4ab6643 
Refs: #28803

PR-URL: #32849
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request May 13, 2020
@sam-github @targos
test: mark test flaky on freebsd
dad8217 
Test name test-worker-message-port-message-before-close is too long for
a commit message description.

Refs: #31280

PR-URL: #32849
Refs: #28803
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 1, 2020
@sam-github @richardlau
test: flaky test-stdout-close-catch on freebsd
5436569 
Refs: #28803

PR-URL: #32849
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@richardlau richardlau mentioned this pull request Jul 2, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sam-github @nodejs-github-bot @addaleax @jasnell @lpinca @richardlau @BridgeAR @juanarbol