vm: throw error when duplicated exportNames in SyntheticModule #32810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Apr 13, 2020
This comment has been minimized.
This comment has been minimized.
targos
reviewed
Apr 13, 2020
devsnek
reviewed
Apr 13, 2020
devsnek
reviewed
Apr 13, 2020
himself65
changed the title
SimenB
reviewed
Apr 13, 2020
SimenB
reviewed
Apr 13, 2020
addaleax
approved these changes
Apr 27, 2020
addaleax
added
the
author ready
targos
approved these changes
Apr 28, 2020
himself65
added a commit
that referenced
this pull request
Apr 28, 2020
Fixes: #32806 PR-URL: #32810 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
|
landed in 9545013 |
targos
pushed a commit
that referenced
this pull request
May 4, 2020
Fixes: #32806 PR-URL: #32810 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 7, 2020
Fixes: #32806 PR-URL: #32810 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 13, 2020
Fixes: #32806 PR-URL: #32810 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #32806
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes