wasi: replace || with ?? #32628
Closed
wasi: replace || with ?? #32628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
wasi
|
Looks like the CI isn't quite ready for the new syntax yet. |
|
fix for ci failure 45c5232 |
|
@devsnek I'm guessing a proper fix is waiting for a release of acorn with acornjs/acorn#890? |
|
@cjihrig it's not just nullish coalescing, it's any feature we want to use that isn't currently implemented by acorn. we could wait for that specific pr but that wouldn't fix the problem imo. |
|
I'm going to close this out for now since it can't land yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codebase is starting to run low on
vars to change tolet/const.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes