Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: include the error type in the request.resolve doc #32152

Closed
wants to merge 1 commit into from
Closed

doc: include the error type in the request.resolve doc #32152

wants to merge 1 commit into from

Conversation

trusktr
Copy link
Contributor

@trusktr trusktr commented Mar 8, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes I'm assuming documentation changes don't impact test results
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Mar 8, 2020
@trusktr
Copy link
Contributor Author

trusktr commented Mar 8, 2020 •
edited
Loading

I figure errors should be documented.

I went to look up the require.resolve documentation because I wanted to know what happens when the module is not found, and the doc didn't say anything about that. It only said that a string is returned, so my initial assumption was that maybe it returned an empty string in the case of a module not found.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2020
@addaleax
Copy link
Member

Landed in a220202

@addaleax addaleax closed this Mar 11, 2020
addaleax pushed a commit that referenced this pull request Mar 11, 2020
@trusktr @addaleax
doc: include the error type in the request.resolve doc
a220202 
PR-URL: #32152
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
@trusktr @MylesBorins
doc: include the error type in the request.resolve doc
28cd36a 
PR-URL: #32152
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
@trusktr @MylesBorins
doc: include the error type in the request.resolve doc
893e918 
PR-URL: #32152
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 12, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@trusktr @targos
doc: include the error type in the request.resolve doc
385faf7 
PR-URL: #32152
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@trusktr @addaleax @cjihrig @BridgeAR @trivikr @nodejs-github-bot