Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: introduce node_sockaddr #32070

Closed
wants to merge 1 commit into from
Closed

src: introduce node_sockaddr #32070

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 3, 2020

Extracted from the QUIC PR to allow for more incremental review.

Introduce the SocketAddress utility class. While not specific to QUIC, the QUIC implementation makes extensive use of this for handling of socket addresses. It was separated out to make it generically reusable throughout core

Signed-off-by: James M Snell [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Mar 3, 2020
@jasnell jasnell requested a review from addaleax March 3, 2020 20:00
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 3, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29526/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29528/

@jasnell
Copy link
Member Author

jasnell commented Mar 4, 2020

Relevant build failure on macos... hopefully fixed up.. trying again

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29536/

@jasnell
Copy link
Member Author

jasnell commented Mar 4, 2020

this is ready to go as soon as the 48 hours is up :-)

lundibundi
lundibundi approved these changes Mar 5, 2020
View reviewed changes
src/node_sockaddr-inl.h Show resolved Hide resolved
@jasnell
src: introduce node_sockaddr
26454dc 
Introduce the SocketAddress utility class. The QUIC implementation
makes extensive use of this for handling of socket addresses. It
was separated out to make it generically reusable throughout core

Signed-off-by: James M Snell <[email protected]>
jasnell added a commit that referenced this pull request Mar 5, 2020
@jasnell
src: introduce node_sockaddr
ba462c2 
Introduce the SocketAddress utility class. The QUIC implementation
makes extensive use of this for handling of socket addresses. It
was separated out to make it generically reusable throughout core

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32070
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Mar 5, 2020

Landed in ba462c2

@jasnell jasnell closed this Mar 5, 2020
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@jasnell @MylesBorins
src: introduce node_sockaddr
4ac1ce1 
Introduce the SocketAddress utility class. The QUIC implementation
makes extensive use of this for handling of socket addresses. It
was separated out to make it generically reusable throughout core

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32070
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2020
Merged
@targos
Copy link
Member

targos commented Apr 20, 2020

Depends on #31871 to land on v12.x

@targos targos removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v12.x labels Apr 25, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@jasnell @targos
src: introduce node_sockaddr
372d30c 
Introduce the SocketAddress utility class. The QUIC implementation
makes extensive use of this for handling of socket addresses. It
was separated out to make it generically reusable throughout core

Signed-off-by: James M Snell <[email protected]>

PR-URL: nodejs#32070
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@jasnell @targos
src: introduce node_sockaddr
83c47b6 
Introduce the SocketAddress utility class. The QUIC implementation
makes extensive use of this for handling of socket addresses. It
was separated out to make it generically reusable throughout core

Signed-off-by: James M Snell <[email protected]>

PR-URL: #32070
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@targos targos mentioned this pull request May 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lundibundi lundibundi lundibundi approved these changes

@richardlau richardlau richardlau approved these changes

@devnexen devnexen devnexen approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jasnell @nodejs-github-bot @targos @addaleax @devnexen @richardlau @lundibundi