Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: always ignore vm-timeout-escape-queuemicrotask #31980

Closed
wants to merge 1 commit into from
Closed

test: always ignore vm-timeout-escape-queuemicrotask #31980

wants to merge 1 commit into from

Conversation

lundibundi
Copy link
Member

Always skip the test as it is not expected to be fixed (probably ever).
Left in the known_issues as an example and 'note' that the issue is
there and won't be fixed.

Follow up #31966.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 27, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29413/

@addaleax addaleax mentioned this pull request Mar 2, 2020
Closed
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 2, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29489/

@mmarchini mmarchini mentioned this pull request Mar 2, 2020
Closed
2 tasks
@mmarchini
Copy link
Contributor

Our CI is treating the skipped test as failing?

09:08:25 not ok 2833 known_issues/test-vm-timeout-escape-queuemicrotask
09:08:25   ---
09:08:25   duration_ms: 0.154
09:08:25   severity: fail
09:08:25   stack: |-
09:08:25     1..0 # Skipped: This issue is unfixable with the current implementations of V8 and Node.js. Changes to make this fixable are unlikely to happen in the foreseeable future. The test itself is flaky and skipped. It serves as a demonstration of the issue only.

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 2, 2020
@richardlau
Copy link
Member

Our CI is treating the skipped test as failing?

known_issues tests are expected to fail (unless specified otherwise in the status file).

@lundibundi
test: always skip vm-timeout-escape-queuemicrotask
4629d51 
This issue is unfixable with the current implementations of V8 and
Node.js. Changes to make this fixable are unlikely to happen in the
foreseeable future. The test itself is flaky and skipped.  It
serves as a demonstration of the issue only.
@lundibundi lundibundi force-pushed the ignore-escape-queuemicrotask branch from e13248c to 4629d51 Compare March 4, 2020 15:53
@lundibundi
Copy link
Member Author

@mmarchini @richardlau @jasnell @lpinca PTAL, removed the skip from the test and put to in the .status file instead.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29537/

@jasnell
Copy link
Member

jasnell commented Mar 4, 2020

Still LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29595/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29671/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29678/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29680/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29698/

@mmarchini
Copy link
Contributor

Landed in 30bbeb7

@mmarchini mmarchini closed this Mar 10, 2020
mmarchini pushed a commit that referenced this pull request Mar 10, 2020
@lundibundi @mmarchini
test: always skip vm-timeout-escape-queuemicrotask
30bbeb7 
This issue is unfixable with the current implementations of V8 and
Node.js. Changes to make this fixable are unlikely to happen in the
foreseeable future. The test itself is flaky and skipped.  It
serves as a demonstration of the issue only.

PR-URL: #31980
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
@lundibundi @MylesBorins
test: always skip vm-timeout-escape-queuemicrotask
4589863 
This issue is unfixable with the current implementations of V8 and
Node.js. Changes to make this fixable are unlikely to happen in the
foreseeable future. The test itself is flaky and skipped.  It
serves as a demonstration of the issue only.

PR-URL: #31980
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 23, 2020
@lundibundi @codebytere
test: always skip vm-timeout-escape-queuemicrotask
5d30570 
This issue is unfixable with the current implementations of V8 and
Node.js. Changes to make this fixable are unlikely to happen in the
foreseeable future. The test itself is flaky and skipped.  It
serves as a demonstration of the issue only.

PR-URL: #31980
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codebytere codebytere mentioned this pull request Mar 24, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@lundibundi @codebytere
test: always skip vm-timeout-escape-queuemicrotask
f79da74 
This issue is unfixable with the current implementations of V8 and
Node.js. Changes to make this fixable are unlikely to happen in the
foreseeable future. The test itself is flaky and skipped.  It
serves as a demonstration of the issue only.

PR-URL: #31980
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 31, 2020
@lundibundi @codebytere
test: always skip vm-timeout-escape-queuemicrotask
7123c0f 
This issue is unfixable with the current implementations of V8 and
Node.js. Changes to make this fixable are unlikely to happen in the
foreseeable future. The test itself is flaky and skipped.  It
serves as a demonstration of the issue only.

PR-URL: #31980
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax left review comments

@Trott Trott Trott left review comments

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@mmarchini mmarchini mmarchini approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@lundibundi @nodejs-github-bot @mmarchini @richardlau @jasnell @Trott @addaleax @lpinca @BridgeAR