Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: make DH error messages consistent #31873

Closed
wants to merge 1 commit into from
Closed

crypto: make DH error messages consistent #31873

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

This custom error message was only added to make sure that #31445 was semver-minor.

Refs: #31178
Refs: #31445

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@tniessen tniessen added crypto Issues and PRs related to the crypto subsystem. semver-major PRs that contain breaking changes and should be released in the next major version. labels Feb 19, 2020
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 19, 2020
@jasnell
Copy link
Member

jasnell commented Feb 19, 2020

Since this is not changing the error code and only touches the error message, it does not need to be semver-major

@jasnell jasnell removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 19, 2020
@tniessen tniessen added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 19, 2020
@tniessen
Copy link
Member Author

@jasnell I think it needs to be, the error code was only added in #31445 (which was not semver-major since it didn't change the error name or message, just the code).

@jasnell
Copy link
Member

jasnell commented Feb 19, 2020

Ah, ok. That original pr should have been semver major

@tniessen
Copy link
Member Author

Mhh really? I talked to another collaborator before creating the PR, and we came to the conclusion that adding a code (as opposed to changing an existing code) isn't breaking behavior, because it is unrealistic that existing code relies on the non-existence of the code property.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29686/

@tniessen
Copy link
Member Author

CitGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2297

Looks normal to me, then again, I find it very difficult to get meaningful information from the failures.

addaleax pushed a commit that referenced this pull request Mar 11, 2020
@tniessen @addaleax
crypto: make DH error messages consistent
1b9a62c 
Refs: #31178
Refs: #31445

PR-URL: #31873
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@addaleax
Copy link
Member

Landed in 1b9a62c

@addaleax addaleax closed this Mar 11, 2020
@BethGriggs BethGriggs mentioned this pull request Mar 17, 2020
Merged
@tniessen tniessen mentioned this pull request Apr 15, 2020
Closed
4 tasks
@joyeecheung joyeecheung mentioned this pull request Jun 8, 2020
Closed
3 tasks
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@devnexen devnexen devnexen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tniessen @jasnell @nodejs-github-bot @addaleax @bnoordhuis @lpinca @cjihrig @devnexen @BridgeAR