lib: refactor isLegalPort, move to validators #31851
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
jasnell
commented
Feb 18, 2020
richardlau
approved these changes
Feb 18, 2020
BridgeAR
reviewed
Feb 18, 2020
BridgeAR
reviewed
Feb 19, 2020
jasnell
added
the
author ready
isLegalPort was used multiple places in the same way -- to validate the port and throw if necessary. Moved into internal/validators.
jasnell
force-pushed
the
refactor-islegalport
branch
from
a100a54
to
5c32715
Compare
jasnell
added a commit
that referenced
this pull request
Mar 5, 2020
isLegalPort was used multiple places in the same way -- to validate the port and throw if necessary. Moved into internal/validators. PR-URL: #31851 Reviewed-By: Richard Lau <[email protected]>
|
Landed in b023d61 |
|
This doesn't land cleanly on v13.x Should it be backported? |
|
after some other backports landed this now lands cleanly! |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 10, 2020
isLegalPort was used multiple places in the same way -- to validate the port and throw if necessary. Moved into internal/validators. PR-URL: #31851 Reviewed-By: Richard Lau <[email protected]>
Merged
3 tasks
2 tasks
targos
added
backport-blocked-v12.x
and removed
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
isLegalPort was used multiple places in the same way -- to validate the port and throw if necessary. Moved into internal/validators. PR-URL: nodejs#31851 Reviewed-By: Richard Lau <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
isLegalPort was used multiple places in the same way -- to validate the port and throw if necessary. Moved into internal/validators. PR-URL: #31851 Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isLegalPort was used multiple places in the same way -- to validate
the port and throw if necessary. Moved into internal/validators.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes