-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream: improve writable.write() performance #31624
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
stream
Issues and PRs related to the stream subsystem.
benchmark
Issues and PRs related to the benchmark subsystem.
performance
Issues and PRs related to the performance of Node.js.
labels
Feb 3, 2020
lpinca
approved these changes
Feb 4, 2020
jasnell
approved these changes
Feb 4, 2020
mcollina
approved these changes
Feb 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
addaleax
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Feb 7, 2020
mscdex
force-pushed
the
stream-writable-write-perf
branch
2 times, most recently
from
February 9, 2020 02:35
9584701
to
dea2b50
Compare
PR-URL: nodejs#31624 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#31624 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
mscdex
force-pushed
the
stream-writable-write-perf
branch
from
February 9, 2020 02:37
568dcf0
to
43783b5
Compare
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
PR-URL: #31624 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
@mscdex this needs a manual backport to v13.x - if it shouldn't be feel free to just swap that label out for |
7 tasks
4 tasks
4 tasks
ronag
pushed a commit
to nxtedition/node
that referenced
this pull request
Mar 10, 2020
PR-URL: nodejs#31624 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Backport-PR-URL: nodejs#32169
MylesBorins
pushed a commit
that referenced
this pull request
Mar 10, 2020
Backport-PR-URL: #32169 PR-URL: #31624 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
PR-URL: #31624 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
PR-URL: #31624 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
PR-URL: #31624 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
benchmark
Issues and PRs related to the benchmark subsystem.
performance
Issues and PRs related to the performance of Node.js.
stream
Issues and PRs related to the stream subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark results:
There is also a change to the benchmark runner to ensure that
end()
is not called multiple times. This was happening in theWritable
benchmark and was at least causing weird display issues (e.g. improper fraction for # of configs, completion percentage bouncing back and forth, etc.) when using benchmark/compare.js and showing progress.The reason why that was happening was that
process.send()
is used to send the result, which is async and gives individual benchmarks time to call.end()
again before the process actually exits.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes