-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: add Int16Array primordials #31205
Closed
Sebastien-Ahkrin
wants to merge
1
commit into
nodejs:master
from
Sebastien-Ahkrin:Int16ArrayPrimordials
Closed
lib: add Int16Array primordials #31205
Sebastien-Ahkrin
wants to merge
1
commit into
nodejs:master
from
Sebastien-Ahkrin:Int16ArrayPrimordials
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: #30697 |
targos
approved these changes
Jan 6, 2020
cjihrig
approved these changes
Jan 6, 2020
trivikr
approved these changes
Jan 6, 2020
jasnell
approved these changes
Jan 6, 2020
BridgeAR
approved these changes
Jan 6, 2020
Trott
approved these changes
Jan 7, 2020
This needs a rebase. |
mhdawson
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Sebastien-Ahkrin Ping. This needs a rebase. |
704d3ab
to
28a624e
Compare
8ae28ff
to
2935f72
Compare
targos
pushed a commit
that referenced
this pull request
Jun 2, 2020
PR-URL: #31205 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Landed in 178efdf. Thanks @Sebastien-Ahkrin |
This was referenced Jun 4, 2020
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #31205 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #31205 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jul 9, 2020
PR-URL: #31205 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
For this PR I have added Int16Array in the primordials eslint
And i just have created a line in "/lib/.eslintrc.yaml".
And just add Int16Array .
I hope this new PR will help you :x