-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vm: introduce vm.Context #30709
vm: introduce vm.Context #30709
Conversation
the |
This comment has been minimized.
This comment has been minimized.
f69a810
to
55e15ff
Compare
@nodejs/vm the |
What's the reasoning behind deprecating |
@joyeecheung it's only docs deprecated. I don't think it would ever be feasible to runtime deprecate it. The idea of this PR is to provide a new API which doesn't act as confusingly (and somewhat dangerously) as the current API, and encourage people to use it. |
55e15ff
to
e8078f4
Compare
e8078f4
to
cb268aa
Compare
I'm still wondering about a |
85acc04
to
0916064
Compare
This needs a rebase. |
0916064
to
23c28fa
Compare
@nodejs/collaborators This needs reviews. |
Fixes #855
Fixes #31658
Fixes #31808
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes