lib,test: improves ERR_REQUIRE_ESM message

[juanarbol]

Fixes: #30599

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[juanarbol]

If this get landed, please re-write that commit message before landing, mine is horrible, haha ):

[juanarbol]

FIxing tests issues

[guybedford]

Looking good, thanks again for working on this.

[juanarbol]

This changes are breaking test/parallel/test-require-mjs.js, I've attached debugger and no idea what's going on.

Output:

assert.js:561
      throw err;
      ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

  Comparison {
+   code: 'ERR_INVALID_ARG_TYPE',
+   message: 'The "path" argument must be of type string. Received type object'
-   code: 'ERR_REQUIRE_ESM',
-   message: /Must use import to load ES Module/
  }
    at Object.<anonymous> (/Users/juanjose/Documents/GitHub/Node/node/test/parallel/test-require-mjs.js:5:8)
    at Module._compile (internal/modules/cjs/loader.js:1185:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1205:10)
    at Module.load (internal/modules/cjs/loader.js:1040:32)
    at Function.Module._load (internal/modules/cjs/loader.js:944:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:67:12)
    at internal/main/run_main_module.js:17:47 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: [NodeError],
  expected: [Object],
  operator: 'throws'
}

[guybedford]

Seems like we're there? Thanks for your persistence on this one!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/27324/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/27334/

[guybedford]

Landed in 81ac302.

[pinguinjkeke]

It introduces a breaking change.
It was emitted as a warning before update to the latest version.
Now it throws the error and prevents execution.

[MylesBorins]

@pinguinjkeke experimental features in Node.js are not covered by the semver contract. More details about this can be found in our docs

We do try and be cautious though. That is part of the reason that we landed this change in a SemverMinor on 12.x and have kept the ESM implementation behind a flag.

I apologise for the inconvenience but I hope you understand that being pragmatic about this will allow us to have a more consistent experience across versions of node when we stabilize the api