Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: unset NODE_VERSION_IS_RELEASE from master #30584

Closed
wants to merge 1 commit into from
Closed

src: unset NODE_VERSION_IS_RELEASE from master #30584

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Nov 22, 2019

No description provided.

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 22, 2019
@targos
Copy link
Member Author

targos commented Nov 22, 2019

This fixes CI, let's fast-track!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26836/

@gireeshpunathil
Copy link
Member

This fixes CI

@targos - curious what issues this was causing in the CI? I have been running and seeing a lot of failures in the CI for the C&L PRs, just want to know are those related some how.

@targos
Copy link
Member Author

targos commented Nov 22, 2019

@gireeshpunathil When that bit is set, test/parallel/test-release-npm is not skipped. On master, that test fails because npm warns that it's not compatible with Node 14.

@MylesBorins
Copy link
Contributor

apologies for missing this

MylesBorins
MylesBorins approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

There is a backlog on CI, this is definitely not going to break anything. I think we should land this immediately and skip waiting for CI.

@gireeshpunathil
Copy link
Member

+1 for landing without waiting for CI - saves a lot of runs.

@MylesBorins
Copy link
Contributor

Landed in 917fedd

MylesBorins pushed a commit that referenced this pull request Nov 22, 2019
@targos @MylesBorins
src: unset NODE_VERSION_IS_RELEASE from master
917fedd 
PR-URL: #30584
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@targos targos deleted the is-release branch November 22, 2019 08:34
@BethGriggs BethGriggs mentioned this pull request Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@addaleax addaleax addaleax approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @nodejs-github-bot @gireeshpunathil @MylesBorins @addaleax