Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify writable.cork method #30442

Closed
wants to merge 8 commits into from
Closed

doc: clarify writable.cork method #30442

wants to merge 8 commits into from

Commits on Nov 12, 2019

  1. Clarify role of writable.cork() 

    The syntax of the sentence describing the role of writable.cork() was unclear. This rephrase aims to make the distinction between writing to the buffer and draining immediately to the underlying resource clearer.
    @GKJCJG
    GKJCJG authored Nov 12, 2019
    Configuration menu
    Copy the full SHA
    521adde View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2019

  1. doc: Clarify role of writable.cork() 

    The syntax of the sentence describing the role of writable.cork() was unclear.
This rephrase aims to make the distinction between writing to the buffer
and draining immediately to the underlying destination clearer - while
keeping performance considerations clearly in mind.
    @GKJCJG
    GKJCJG authored Nov 14, 2019
    Configuration menu
    Copy the full SHA
    a4c2e36 View commit details
    Browse the repository at this point in the history

  2. Improving syntax minorly.

    @GKJCJG
    GKJCJG authored Nov 14, 2019
    Configuration menu
    Copy the full SHA
    61d7d1f View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2019

  1. Simplify description of performance problems

    @GKJCJG
    GKJCJG authored Nov 17, 2019
    Configuration menu
    Copy the full SHA
    3fbb958 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2019

  1. Adopt suggestions from mcollina 

    More detailed explanation of underlying dynamics.
    @GKJCJG
    GKJCJG authored Nov 21, 2019
    Configuration menu
    Copy the full SHA
    5ba141a View commit details
    Browse the repository at this point in the history

  2. removing forbidden strings and fixing link.

    @GKJCJG
    GKJCJG authored Nov 21, 2019
    Configuration menu
    Copy the full SHA
    845738c View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2019

  1. Update doc/api/stream.md 

    Co-Authored-By: Anna Henningsen <[email protected]>
    @GKJCJG @addaleax
    GKJCJG and addaleax authored Dec 3, 2019
    Configuration menu
    Copy the full SHA
    cde9d5f View commit details
    Browse the repository at this point in the history

  2. Update doc/api/stream.md 

    Co-Authored-By: Anna Henningsen <[email protected]>
    @GKJCJG @addaleax
    GKJCJG and addaleax authored Dec 3, 2019
    Configuration menu
    Copy the full SHA
    c2b161a View commit details
    Browse the repository at this point in the history