v12.13.1 release proposal #30352
Merged
v12.13.1 release proposal #30352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is not entirely clear why this condition is being triggered, it does resolve a reported bug. Fixes: #26315 PR-URL: #29912 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This commit removes unused using declarations in src/node_worker.cc. PR-URL: #29883 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #29845 Refs: #29842 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Closing a FileHandle almost never fails, so it was hard to notice before that `stream.emit(err)` would not emit an error event due to the missing event name. Destroying the stream with the error seems like the right thing to do in that scenario. PR-URL: #29884 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
PR-URL: #29823 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Read up to 32 directory entries in one batch when `dir.readSync()`
or `dir.read()` are called.
This increases performance significantly, although it introduces
quite a bit of edge case complexity.
confidence improvement accuracy (*) (**) (***)
fs/bench-opendir.js mode='async' dir='lib' n=100 *** 155.93 % ±30.05% ±40.34% ±53.21%
fs/bench-opendir.js mode='async' dir='test/parallel' n=100 *** 479.65 % ±56.81% ±76.47% ±101.32%
fs/bench-opendir.js mode='sync' dir='lib' n=100 10.38 % ±14.39% ±19.16% ±24.96%
fs/bench-opendir.js mode='sync' dir='test/parallel' n=100 *** 63.13 % ±12.84% ±17.18% ±22.58%
PR-URL: #29893
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
PR-URL: #29893 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
PR-URL: #29909 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
During the addition of macOS support for large pages, a `memcpy` ended up under the wrong preprocessor directive. As a result, the newly allocated large pages were not initialized with a copy of the text section. Thanks to Suresh Srinivas <[email protected]>! PR-URL: #29914 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]>
Fixes: #29904 PR-URL: #29913 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
* Fix sorting of sections. * Fix sorting of bottom references. * Wrap lines at 80 chars. * Fix a heading level. PR-URL: #29906 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
The two-week wait period for merging npm releases is one of those rule exceptions that would be great to get rid of (in my opinion at least). There are too many exceptions to our rules and they tend to be scattered across multiple documents. People don't feel confident they know the rules, thus hampering both project velocity and Collaborator confidence. It also means I (and perhaps others?) get lots of pings about whether this or that can land, etc. This particular issue has come up a few times lately, and is specifically calling for an exception-to-the-exception so that the latest version of npm can be released along with Node.js 13.0.0. Refs: #29885 (comment) I propose here reducing the wait period from two weeks to one week. If, after some amount of time, there seems to be no problems caused by this change, we can consider further reducing the wait period to 48 hours to align it with all other change requests. Even if you think that is going too far, hopefully we can at least get it reduced to a week, as the second week of the waiting period is usually just the PR sitting around with an occasional ping from someone about whether/when it can land. PR-URL: #29922 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
This removes `require('util')` from the `domain` module. There was
only a single simple type check used from the `util` module which
is now inlined instead.
PR-URL: #29825
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Since worker threads are complete Node.js environments, including the ability to load native addons, and since those native addons can allocate resources to be freed when objects go out of scope, and since, upon worker thread exit, the engine does not invoke the weak callbacks responsible for freeing resources which still have references, this modification introduces tracking for weak references such that a list of outstanding weak references is maintained. This list is traversed during environment teardown. The callbacks for the remaining weak references are called. This change is also relevant for Node.js embedder scenarios, because in those cases the process also outlives the `node::Environment` and therefore weak callbacks should also be rendered as environment cleanup hooks to ensure proper cleanup after native addons. This changes introduces the means by which this can be accomplished. A benchmark is included which measures the time it takes to execute the weak reference callback for a given number of weak references. Re: tc39/proposal-weakrefs#125 (comment) PR-URL: #28428 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Refs: nodejs/node-gyp#1820 Refs: nodejs/node-gyp#1843 PR-URL: #29897 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
If GYP finds a string variable that can be converted to an integer, it will do it when the variable is expanded. Use "0.0" instead of "0" to force strings and be able to use comparison operations such as `gas_version >= "2.26"` in Python 3. PR-URL: #29897 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
PR-URL: #29897 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
PR-URL: #29956 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Make `distutils.version.StrictVersion` available as a helper to gyp expressions so they can do proper version checks and update the gyp files accordingly. Caveat emptor: `StrictVersion` does *not* like empty strings so this commit adds truthiness guards. The helper could deal with those but I felt it better to make it explicit. Fixes: #29927 PR-URL: #29931 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Without the line lengths of in-memory transpiled source, it's not possible to convert from byte ofsets to line/column offsets. PR-URL: #29863 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
Add missing option "mode". Alphabetize options for easier maintenance. PR-URL: #29967 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]>
Prepare the final few documents that haven't been updated to always use `[]` with reference links and to escape `[` and `]` for things that aren't links in markdown files. PR-URL: #29963 Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Doctool tests have been failing a lot in CI on Win2008 R2. It appears async functions and callback-based functions are being used in combination such that the callback-based function cannot guarantee that it will invoke its callback. Convert the callback-based functions to async functions so we have one paradigm and reliable results. PR-URL: #29979 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
PR-URL: #29962 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #29961 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: #29961 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Provides some missing test coverage. PR-URL: #29970 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Multiple sections may be marked as "r-xp" and with the executable's path. We use the location of the `__nodetext` symbol added by the linker script to ensure that the range we retrieve from the maps file does indeed contain the Node.js text section. Thanks to Suresh Srinivas <[email protected]>! PR-URL: #29973 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
PR-URL: #29950 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Currently `--es-module-specifier-resolution=node` has an alternative resolution order than the default in common.js, this causes inconsistencies. As discussed in @nodejs/modules we want to preserve resolution order between implementations. PR-URL: #29974 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
New RC build: https://ci-release.nodejs.org/job/iojs+release/4840/ Edit: download at https://nodejs.org/download/rc/v12.13.1-rc.1/ |
|
The AIX release build failed twice. @nodejs/build |
npm requires crypto support and cannot be loaded without it. PR-URL: #30265 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Notable changes: * Experimental support for building Node.js with Python 3 is improved. * ICU time zone data is updated to version 2019c. This fixes the date offset in Brazil. PR-URL: #30352
targos
force-pushed
the
v12.13.1-proposal
branch
from
d58857c
to
525fd9c
Compare
|
Added af544ab to fix CI. |
|
@nodejs/lts |
|
one failure: 143 is killed with SIGTERM. I am doing the checkout manually in the ws, and it is indeed very, very slow. Got to about 2020/3123 and its now at about 1 per 2 seconds, so it'll be more than 30 minutes to complete. I'm looking into why. |
|
Almost certainly because no ramdisks are mounted. |
|
@targos I mounted /home/iojs/build onto a ramdisk, should be faster, can you confirm? |
|
New build: https://ci-release.nodejs.org/job/iojs+release/4844/ Edit: download at https://nodejs.org/download/rc/v12.13.1-rc.2/ |
BethGriggs
approved these changes
Nov 15, 2019
codebytere
approved these changes
Nov 15, 2019
richardlau
approved these changes
Nov 15, 2019
gengjiawen
approved these changes
Nov 19, 2019
targos
added a commit
that referenced
this pull request
Nov 19, 2019
Notable changes: * Experimental support for building Node.js with Python 3 is improved. * ICU time zone data is updated to version 2019c. This fixes the date offset in Brazil. PR-URL: #30352
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Nov 19, 2019
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Nov 19, 2019
targos
added
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2019-11-19, Version 12.13.1 'Erbium' (LTS), @targos
Notable changes
offset in Brazil.
Commits
56be32d22d] - async_hooks: only emitafterfor AsyncResource if stack not empty (Anna Henningsen) #30087e16e3d5b90] - benchmark: remove double word "then" in comments (Nick Schonning) #29823dcdb96c7bb] - benchmark: add benchmark for vm.createContext (Joyee Cheung) #29845680e9cc7e1] - buffer: improve performance caused by primordials (Jizu Sun) #30235bcd2238b3e] - build: add workaround for WSL (gengjiawen) #30221c5d312f821] - build: find Python syntax errors in dependencies (Christian Clauss) #30143468f203809] - build: fix pkg-config search for libnghttp2 (Ben Noordhuis) #301450415dd7cb3] - build: python3 support for configure (Rod Vagg) #30047032c23d360] - build: make linter failures failtest-doctarget (Richard Lau) #30012a86648c8d2] - build: log the found compiler version if too old (Richard Lau) #3002802f6e5cc40] - build: fix version checks in configure.py (Michaël Zasso) #29965a1adce1b4f] - build: build benchmark addons like test addons (Richard Lau) #29995735ec1bf96] - build: fix version checks in gyp files (Ben Noordhuis) #299318da83e8c24] - build: always use strings for compiler version in gyp files (Michaël Zasso) #29897b7bdfd346c] - crypto: guard with OPENSSL_NO_GOST (Shelley Vohr) #30050e175d0beb6] - crypto: reject public keys properly (Tobias Nießen) #29913b1529c6bc2] - deps: V8: cherry-pick a7dffcd767be (Christian Clauss) #302186bc7a6db0e] - deps: V8: cherry-pick e5dbc95 (Gabriel Schulhof) #30130b88314f735] - deps: update npm to 6.12.1 (Michael Perrotte) #30164ce49a412ef] - deps: V8: cherry-pick c721203 (Michaël Zasso) #30065d2756fd14d] - deps: V8: cherry-pick ed40ab1 (Michaël Zasso) #3006458c585e3ed] - deps: npm: patch support for 13.x (Jordan Harband) #300792764567f90] - deps: upgrade to libuv 1.33.1 (Colin Ihrig) #2999633bd1281fc] - doc: add missing hash for header link (Nick Schonning) #30188b159b91798] - doc: linkify.setupMaster()in cluster doc (Trivikram Kamat) #302049c4a9e7337] - doc: explain http2 aborted event callback (dev-313) #30179d7bfc6c987] - doc: linkify.fork()in cluster documentation (Anna Henningsen) #30163a71f210206] - doc: update AUTHORS list (Michaël Zasso) #301427b5047454b] - doc: improve doc Http2Session:Timeout (dev-313) #301610efe9a0c97] - doc: move inactive Collaborators to emeriti (Rich Trott) #3017798d31da342] - doc: add options description for send APIs (dev-313) #29868d0f5bc1aa7] - doc: fix an error in resolution algorithm steps (Alex Zherdev) #2994028db99932a] - doc: remove incorrect and outdated example (Tobias Nießen) #30138c2108d4919] - doc: adjust code sample for stream.finished (Cotton Hou) #299832ac76e3055] - doc: remove "it is important to" phrasing (Rich Trott) #30108ec992878e8] - doc: revise os.md (Rich Trott) #30102a56e78c8c8] - doc: delete "a number of" things in the docs (Rich Trott) #30103ee954d5570] - doc: remove dashes (Rich Trott) #30101c4c8e01af1] - doc: add legendecas to collaborators (legendecas) #3011522e10fd15a] - doc: --enable-source-maps and prepareStackTrace are incompatible (Benjamin Coe) #30046870c320f31] - doc: join parts of disrupt section in cli.md (vsemozhetbyt) #300388df5bdbd66] - doc: update collaborator email address (Minwoo Jung) #30007d9b5508fc8] - doc: fix tls version typo (akitsu-sanae) #299845616f22839] - doc: clarify readable.unshift null/EOF (Robert Nagy) #29950b57fe3b370] - doc: remove unused Markdown reference links (Nick Schonning) #2996112f24542b8] - doc: re-enable passing remark-lint rule (Nick Schonning) #29961c0cbfae0e3] - doc: add server header into the discarded list of http message.headers (Huachao Mao) #29962a23b5cbf61] - doc: prepare miscellaneous docs for new markdown lint rules (Rich Trott) #29963c66bc20bbf] - doc: fix some recent nits in fs.md (vsemozhetbyt) #299061fefd7fddc] - doc: fs dir modifications may not be reflected by dir.read (Anna Henningsen) #2989366c6818473] - doc,meta: prefer aliases and stubs over Runtime Deprecations (Rich Trott) #301535ade490505] - doc,meta: reduce npm PR wait period to one week (Rich Trott) #299220ec63ee27a] - doc,n-api: sort bottom-of-the-page references (Gabriel Schulhof) #301248a333a4519] - domain: do not import util for a simple type check (Ruben Bridgewater) #2982594ac44f3fc] - esm: modify resolution order for specifier flag (Myles Borins) #29974216e200fa9] - fs: buffer dir entries in opendir() (Anna Henningsen) #298935959023b76] - http2: fix file close error condition at respondWithFd (Anna Henningsen) #298844277066afd] - inspector: turn platform tasks that outlive Agent into no-ops (Anna Henningsen) #30031b0837fead3] - meta: use contact_links instead of issue templates (Michaël Zasso) #301722695f822bc] - module: warn on require of .js inside type: module (Guy Bedford) #29909ee3c3ad0f5] - n-api,doc: add info about building n-api addons (Jim Schlight) #30032da58301054] - net: treat ENOTCONN at shutdown as success (Anna Henningsen) #2991262bc80c906] - process: add lineLength to source-map-cache (Benjamin Coe) #29863ab03c29587] - src: isolate->Dispose() order consistency (Shelley Vohr) #30181c52b292adf] - src: change env.h includes for forward declarations (Alexandre Ferrando) #30133b215b1665a] - src: split up InitializeContext (Shelley Vohr) #30067d586070388] - src: allow inspector without v8 platform (Shelley Vohr) #30049f6655b41fa] - src: remove unnecessary std::endl usage (Daniel Bevenius) #30003abfac9640e] - src: make implementing CancelPendingDelayedTasks for platform optional (Anna Henningsen) #30034693bf73b06] - src: expose ListNode<T>::prev_ on postmortem metadata (legendecas) #300274b57088c25] - src: fewer uses of NODE_USE_V8_PLATFORM (Shelley Vohr) #300296269a3c92a] - src: remove unused iomanip include (Daniel Bevenius) #30004aa0aacbba9] - src: initialize openssl only once (Sam Roberts) #2999945c5ad7922] - src: refine maps parsing for large pages (Gabriel Schulhof) #29973aac2476346] - src: render N-API weak callbacks as cleanup hooks (Gabriel Schulhof) #28428f3115c4d62] - src: fix largepages regression (Gabriel Schulhof) #29914ddbf150edb] - src: remove unused using declarations in worker.cc (Daniel Bevenius) #298838a31136a95] - stream: extract Readable.from in its own file (Matteo Collina) #3014021a43bd2fd] - stream: simplify uint8ArrayToBuffer helper (Luigi Pinca) #30041ae390393b6] - stream: remove dead code (Luigi Pinca) #3004156e986aa23] - test: do not run release-npm test without crypto (Michaël Zasso) #30265d96e8b662e] - test: use arrow functions for callbacks (Minuk Park) #3006900dab3495d] - test: verify npm compatibility with releases (Michaël Zasso) #30082ecf6ae89f4] - test: expand Worker test for non-shared ArrayBuffer (Anna Henningsen) #300442ebd1a0d3f] - test: fix test runner for Python 3 on Windows (Michaël Zasso) #300239fed62f7cb] - test: remove common.skipIfInspectorEnabled() (Rich Trott) #299933e39909022] - test: add cb error test for fs.close() (Matteo Rossi) #29970b93c8a77a3] - test: fix flaky doctool and test (Rich Trott) #29979aec8e77ae1] - test: fix fs benchmark test (Rich Trott) #29967b9fd18f9fb] - tools: pull xcode_emulation.py from node-gyp (Christian Clauss) #302722810f1aec3] - tools: update tzdata to 2019c (Myles Borins) #3047841d1f166bc] - tools: fix Python 3 deprecation warning in test.py (Loris Zinsou) #30208b6546736a0] - tools: fix Python 3 syntax error in mac_tool.py (Christian Clauss) #3014687cb6b2418] - tools: use print() function in buildbot_run.py (Christian Clauss) #30148309c395aba] - tools: undefined name opts -> args in gyptest.py (Christian Clauss) #30144df0fbf2e46] - tools: git rm -r tools/v8_gypfiles/broken (Christian Clauss) #30149375f349760] - tools: update ESLint to 6.6.0 (Colin Ihrig) #301230b6fb3d1db] - tools: doc: improve async workflow of generate.js (Theotime Poisseau) #301068d030131a4] - tools: fix test runner in presence of NODE_REPL_EXTERNAL_MODULE (Gus Caplan) #2995659033f618a] - tools: fix GYP MSVS solution generator for Python 3 (Michaël Zasso) #2989741430bea3c] - tools: port Python 3 compat patches from node-gyp to gyp (Michaël Zasso) #29897