src: replace some FIXED_ONE_BYTE_STRING call with env->something_string() in src/ #30266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
gireeshpunathil
added
the
code-and-learn
replace FIXED_ONE_BYTE_STRING call with env->something_string() in src/api/environment.cc, src/api/hooks.cc and src/async_wrap.cc Fixes: nodejs/code-and-learn#97 Refs: nodejs/code-and-learn#97
addaleax
reviewed
Nov 5, 2019
| @@ -508,7 +508,7 @@ void AsyncWrap::Initialize(Local<Object> target, | |||
| env->async_hooks()->async_ids_stack().GetJSArray()).Check(); | |||
|
|
|||
| target->Set(context, | |||
| FIXED_ONE_BYTE_STRING(env->isolate(), "owner_symbol"), | |||
| env->owner_symbol_string(), | |||
| env->owner_symbol()).Check(); | |||
There was a problem hiding this comment.
I think we could actually drop this property altogether and use internalBinding ('symbols') in JS land instead
There was a problem hiding this comment.
To elaborate: you can replace the owner_symbol here:
node/lib/internal/async_hooks.js
Line 36 in 618fcbd
with const { owner_symbol } = internalBinding('symbols')
And remove this part in C++.
|
ping @js00070, see comment above. |
|
ping @js00070 again |
|
sorry guys, I'm not familiar with the architecture of nodejs now. I have been busy recently. I can close this PR temporarily. I will try to contribute to nodejs after spending some time reading the source code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace
FIXED_ONE_BYTE_STRINGcall withenv->something_string()insrc/api/environment.cc,src/api/hooks.ccandsrc/async_wrap.ccthis task is a part of nodejs/code-and-learn#97
Checklist
make -j2 test(UNIX) passes