Revert "stream: invoke callback before emitting error always" #29741
Conversation
This reverts commit 3de5eae.
nodejs-github-bot
added
the
stream
|
node-daily-master to confirm master is broken: https://ci.nodejs.org/view/Node.js%20Daily/job/node-daily-master/1691/ |
It's failing. I propose we fast track this revert. @nodejs/collaborators: Please 👍 here if you approve fast-tracking this revert to fix the build. |
Trott
added
author ready
|
Alternative which fixes bug instead of fully reverting: #29742 |
|
This has sufficient approvals/fast-track/CI to land, but I'd be good with #29742 instead so I'm holding off a bit to see if that can land instead. (But that shouldn't stop someone else from landing this if they think it's the right thing to do or need to fix CI immediately.) |
|
I prefer to revert this and have a follow-up PR that readd that behavior. |
| type: Error, | ||
| message: 'Cannot call write after a stream was destroyed' | ||
| } | ||
| ); | ||
| })); |
There was a problem hiding this comment.
This updated test is what's causing the failure. Only reverting this part would also make CI pass.
|
Going to land this since it's been a few hours and it's still the only one that's ready to go. Sorry for the bit of extra work that will mean for you, @ronag. |
|
Landed in 95792a7 |
This reverts commit 3de5eae. PR-URL: #29741 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This reverts commit 3de5eae.
Refs: #29293 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes